Display server version at startup when not running from git repository

[gklyne]

See #1110, #1111

This fix raises an error when the version information returned by running git is empty, thereby falling back to using package.json. (This is a new attempt to submit previous PR #1111, but this time based upon and updating the release/v5.0.0 branch.)

[megoth]

LGTM

[linonetwo]

Why it is showing Solid server (v0.33.8)?

I've installed latest v5.1.5 , is this a bug or a feature?

[gklyne]

@linonetwo I'd check to see what git describe --tags is returning when run from the bin/cli directory. (My fix should only affect installs that are not from a local git repo.)

[linonetwo]

I've install solid via npm i -g.

After install, it shows 5.1.5 installed, but then I run solid -V shows Solid server (v0.33.8)

[kjetilk]

strange... I can't reproduce, and I don't know what could produce such a result. What does
which solid say? Could it be something else entirely?

[gklyne]

Is it possible that the npm install is inside some other git repository?

Running git status, or git describe --tags, in the directory with the installed software (i.e. the directory from which solid) might quickly eliminate this possibility.

[linonetwo]

It is not a git repo:

~$ which solid
~/.nvm/versions/node/v12.4.0/bin/solid
~$ solid -V
v0.33.8
~$ cd ~/.nvm/versions/node/v12.4.0/bin && git status
Not currently on any branch.
nothing to commit, working directory clean
~/.nvm/versions/node/v12.4.0/bin$

[gklyne]

Thanks - I agree, it's not that.

Next places I'd look are:

.../bin/lib/cli.js, line 33:

  } catch (e) {
    // Obtain version from package.json
    const { version } = require(path.join(__dirname, '../../package.json'))
    return version
  }

.../package.json, line 4:

  "version": "5.1.5",

Beyond that, as far as I can tell, the version display is handled by the commander command line parser.

I'd be tempted to try inserting a console.log(version) in cli.js before the return version to (a) confirm it's taking that code path, and (b) check the value of version that comes from package.json. If it's correct the then it looks as if going astray in the handoff to commander at line 11: program.version(getVersion())

[linonetwo]

Oh, note that, even if git status returns Not currently on any branch.,

git describe --tags can still return something:

xxx@xxx-ubuntu:~/.nvm/versions/node/v12.4.0/bin$ git describe --tags
v0.33.8

xxx@xxx-ubuntu:~/.nvm/versions/node/v12.4.0/bin$ git status
Not currently on any branch.
nothing to commit, working directory clean

xxx@xxx-ubuntu:~/.nvm/versions/node/v12.4.0/bin$ cat ../../package.json
cat: ../../package.json: No such file or directory