Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission to enabling Travis temporarily to add string_decoder #79

Closed
mcollina opened this issue Mar 1, 2018 · 7 comments
Closed

Permission to enabling Travis temporarily to add string_decoder #79

mcollina opened this issue Mar 1, 2018 · 7 comments

Comments

@mcollina
Copy link
Member

mcollina commented Mar 1, 2018

May I do it? Are there a set of things I need to worry about when doing so?

Repo: https://github.com/nodejs/string_decoder
Issue: nodejs/string_decoder#5
Projects we are testing on travis: https://travis-ci.org/nodejs

I know @Fishrock123 has done this in the past, and we are running several builds on travis.

Ref #68

cc @joyeecheung.

@mcollina
Copy link
Member Author

mcollina commented Mar 1, 2018

Another approach we can agree on is that I move the repo to my personal profile, enable it, and then move it back. For #68 to work Travis needs to be enabled externally.

@joyeecheung
Copy link
Member

Both SGTM.

@bnoordhuis
Copy link
Member

IIRC, Travis wants private (or was it write?) access to the organization. We moved most of the sensitive repos out of the org but e.g. nodejs/security is still a thing.

@targos
Copy link
Member

targos commented Mar 2, 2018

nodejs/security moved to nodejs-private. There is only one sensitive repo left in this organization: the moderation repo.

Edit: there is also nodejs/members

@mcollina
Copy link
Member Author

mcollina commented Mar 2, 2018

Do you prefer?

  1. enable Travis / set up repo / disable Travis 🎉
  2. move repo to github.com/mcollina, set up repo, move repo back to github.com/nodejs 👍

@mcollina
Copy link
Member Author

mcollina commented Mar 5, 2018

Alternatively, can someone from @nodejs/build set up a CI environement identical to the one of readable-stream?

(also readable-stream Travis integration is broken as well).

@Trott
Copy link
Member

Trott commented Jul 5, 2019

Closing stuff that has been inactive for more than a year in this repo, but if someone plans on picking this up, just go ahead and re-open! No strong opinions from me. Just tidying.

@Trott Trott closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants