Skip to content

Conversation

@KevinEady
Copy link
Contributor

@KevinEady KevinEady commented Oct 28, 2025

  • Add support for Napi::SharedArrayBuffer
  • Add Value::IsSharedArrayBuffer()
  • Update docs and tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.48%. Comparing base (60d439e) to head (6d1aa6c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1688   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files           3        3           
  Lines        2046     2046           
  Branches      728      728           
=======================================
  Hits         1299     1299           
  Misses        162      162           
  Partials      585      585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevinEady KevinEady marked this pull request as ready for review October 28, 2025 14:11
@KevinEady
Copy link
Contributor Author

We see in the tests:

  • standard 24.x: Skipped (no SharedArrayBuffer support) [job]
  • experimental 24.x: no skipped message [job]
  • experimental 20.x: Skipped (no SharedArrayBuffer support) as the underlying node-api feature is not in this version [job]

@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Nov 7, 2025
@KevinEady
Copy link
Contributor Author

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test case in https://github.com/nodejs/node-addon-api/blob/main/test/value_type_cast.cc as well? Or we can add it as a follow-up.

@KevinEady KevinEady marked this pull request as draft November 28, 2025 15:46
@KevinEady KevinEady marked this pull request as ready for review December 3, 2025 20:55
@KevinEady
Copy link
Contributor Author

KevinEady commented Dec 3, 2025

@legendecas, I added the value_type_cast test! PTAL

@legendecas legendecas merged commit 220bee2 into main Dec 4, 2025
115 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project Dec 4, 2025
@legendecas legendecas deleted the add-sharedarraybuffer branch December 4, 2025 11:11
@github-actions github-actions bot mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants