feat: add node-addon-api example for async_work_promise #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEady
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Hi @matthewkeil ,
Thanks for your submission!
We don't usually put TypeScript in our examples. Could you remove the typings as well as test.ts, incorporating its functionality directly in index.js?
Some of our other examples run by doing npm i && node . ... It would be nice to have that same paradigm here 👍
And if you could add new-lines to the end of your files too 👍
|
@KevinEady Thanks for the quick review!! I touched up everything and added a few extra comments for clarity to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a TypeScript example for node-addon-api Napi::AsyncWoker and that is Promise based.