Please sign in to comment.
test: remove common.isOSXMojave
common.isOSXMojave was added because it was believed that there was a bug in macOS Mojave that allowed unprivileged users to bind to privileged ports. As it turns out, that was a feature not a bug. It is likely to be in all future versions of macOS. Remove isOSXMojave and skip appropriate tests based on isOSX. Refs: https://news.ycombinator.com/item?id=18302380 PR-URL: #25658 Reviewed-By: Refael Ackermann <email@example.com> Reviewed-By: Colin Ihrig <firstname.lastname@example.org> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <email@example.com> Reviewed-By: Luigi Pinca <firstname.lastname@example.org> Reviewed-By: Gus Caplan <email@example.com> Reviewed-By: Minwoo Jung <firstname.lastname@example.org>
- Loading branch information...
Showing with 4 additions and 7 deletions.