Skip to content

Commit 5c014bb

Browse files
TrottFishrock123
authored andcommitted
doc: standardize on make -j8
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs. PR-URL: #8678 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
1 parent 8282d6f commit 5c014bb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
99
##### Checklist
1010
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
1111

12-
- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes
12+
- [ ] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes
1313
- [ ] tests and/or benchmarks are included
1414
- [ ] documentation is changed or added
1515
- [ ] commit message follows commit guidelines

0 commit comments

Comments
 (0)