Skip to content

Commit 65bd225

Browse files
danbevjasnell
authored andcommitted
test: fix warning in dlopen-ping-pong/binding.cc
Currently, the following compiler warning is issued: ../binding.cc:26:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations] const String::Utf8Value filename(args[0]); ^ This commit updates the code to use the Isolate version. PR-URL: #19966 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 86c1f19 commit 65bd225

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/addons/dlopen-ping-pong/binding.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ typedef const char* (*ping)(void);
2323
static ping ping_func;
2424

2525
void LoadLibrary(const FunctionCallbackInfo<Value>& args) {
26-
const String::Utf8Value filename(args[0]);
26+
const String::Utf8Value filename(args.GetIsolate(), args[0]);
2727
void* handle = dlopen(*filename, RTLD_LAZY);
2828
assert(handle != nullptr);
2929
ping_func = reinterpret_cast<ping>(dlsym(handle, "dlopen_ping"));

0 commit comments

Comments
 (0)