Skip to content
Permalink
Browse files

src: add missing "http_parser.h" include

In 9d52222 the indirect "http_parser.h"
include was removed, which made `NODE_STRINGIFY()` fail silently for the
http parser version in `process.versions`.

PR-URL: #12464
Fixes: #12463
Ref: #12366
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
  • Loading branch information...
addaleax authored and jasnell committed Apr 17, 2017
1 parent 0584aeb commit 6a1275dfec13960d182ada96752b30aac40e1e27
Showing with 9 additions and 0 deletions.
  1. +1 −0 src/node.cc
  2. +8 −0 test/parallel/test-process-versions.js
@@ -54,6 +54,7 @@
#include "env.h"
#include "env-inl.h"
#include "handle_wrap.h"
#include "http_parser.h"
#include "req-wrap.h"
#include "req-wrap-inl.h"
#include "string_bytes.h"
@@ -20,3 +20,11 @@ expected_keys.sort();
const actual_keys = Object.keys(process.versions).sort();

assert.deepStrictEqual(actual_keys, expected_keys);

assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.ares));
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.http_parser));
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.node));
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.uv));
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.zlib));
assert(/^\d+\.\d+\.\d+\.\d+$/.test(process.versions.v8));
assert(/^\d+$/.test(process.versions.modules));

0 comments on commit 6a1275d

Please sign in to comment.
You can’t perform that action at this time.