src: use correct way to signal interceptor error

targos · RafaelGSS · commit 88d789aca4ed · 2024-08-25T18:20:50.000-03:00
PR-URL: #54418 Refs: https://github.com/nodejs/node/blob/e4f61de14f8cfb83f1ce0ad1597b86278cd5f5f1/deps/v8/include/v8-function-callback.h#L398-L408 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
diff --git a/src/node_webstorage.cc b/src/node_webstorage.cc
@@ -572,8 +572,8 @@ static Intercepted StorageSetter(Local<Name> property,
   Storage* storage;
   ASSIGN_OR_RETURN_UNWRAP(&storage, info.This(), Intercepted::kNo);
 
-  if (storage->Store(property, value)) {
-    info.GetReturnValue().Set(value);
+  if (!storage->Store(property, value)) {
+    info.GetReturnValue().SetFalse();
   }
 
   return Intercepted::kYes;

Original file line number	Diff line number	Diff line change
`@@ -572,8 +572,8 @@ static Intercepted StorageSetter(Local<Name> property,`
`572`	`572`	`Storage* storage;`
`573`	`573`	`ASSIGN_OR_RETURN_UNWRAP(&storage, info.This(), Intercepted::kNo);`
`574`	`574`
`575`		`- if (storage->Store(property, value)) {`
`576`		`- info.GetReturnValue().Set(value);`
	`575`	`+ if (!storage->Store(property, value)) {`
	`576`	`+ info.GetReturnValue().SetFalse();`
`577`	`577`	`}`
`578`	`578`
`579`	`579`	`return Intercepted::kYes;`