Skip to content
Permalink
Browse files

test: add override to ServerDone function

Currently the following compiler warning is displayed when building:

  ../test/cctest/test_inspector_socket_server.cc:142:8: warning:
  'ServerDone' overrides a member function but is not marked 'override'
        [-Winconsistent-missing-override]
    void ServerDone() {
         ^
  ../src/inspector_socket_server.h:30:16: note: overridden virtual
  function is here
    virtual void ServerDone() = 0;
                 ^

This commit marks ServerDone with override to get rid of the warning.

PR-URL: #13166
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information...
danbev authored and jasnell committed May 23, 2017
1 parent c15fe8b commit b781fa7b06530b586f6c5a2aeecd33de86be0b97
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/cctest/test_inspector_socket_server.cc
@@ -139,7 +139,7 @@ class TestInspectorServerDelegate : public SocketServerDelegate {
server_->Send(session_id_, message);
}

void ServerDone() {
void ServerDone() override {
done = true;
}

0 comments on commit b781fa7

Please sign in to comment.
You can’t perform that action at this time.