Please sign in to comment.
build: fix ninja build failure
When working on commit 6a09a69 ("build: enable cctest to use generated objects") I did not take into account building with ninja: $ ./configure $ tools/gyp_node.py -f ninja $ ninja -C out/Release $ ln -fs out/Release/node node When ninja generated the ninja build files, src files that are relative to the src directory will be named with a dot instead of a path separator, for example: out/Release/obj/src/node/node.o would instead become: out/Release/obj/src/node.node.o This commit adds an additional variable for the type of object separator used for this case. Currently the check for if ninja is being used is a normal if statement as are the following os checks (win and aix). But the win and aix ones should only be evaluated if the build is not generated by ninja. This commit turns this logic into an if ninja else statement. PR-URL: #12484 Fixes: #12448 Reviewed-By: Benjamin Gruenbaum <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Refael Ackermann <email@example.com> Reviewed-By: Gibson Fahnestock <firstname.lastname@example.org>
- Loading branch information...