Permalink
Browse files

test: move test-vm-function-redefinition to parallel

With the upstream fix in V8, function declarations now
work fine in the vm module and the test is no longer failing.

Refs: https://codereview.chromium.org/2334733002
Fixes: #548
PR-URL: #9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information...
fhinkel authored and targos committed Sep 16, 2016
1 parent b37f55a commit c2c6ae52eaf302da9c106699b69d17c083ced316
Showing with 0 additions and 0 deletions.
  1. 0 test/{known_issues → parallel}/test-vm-function-redefinition.js

5 comments on commit c2c6ae5

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Jan 29, 2017

Member

@fhinkel fyi, this test fails in debug mode:

Path: parallel/test-vm-function-redefinition
#
# Fatal error in ../deps/v8/src/lookup.h, line 226
# Check failed: has_property_.
#

==== C stack trace ===============================

    out/Debug/node(v8::base::debug::StackTrace::StackTrace()+0x1d) [0x27929ad]
    out/Debug/node(V8_Fatal+0x10b) [0x278f0eb]
    out/Debug/node(v8::internal::LookupIterator::property_details() const+0x3d) [0x166b549]
    out/Debug/node() [0x219c6ca]
    out/Debug/node() [0x219cdd3]
    out/Debug/node() [0x219d2e1]
    out/Debug/node(v8::internal::Runtime_DeclareGlobals(int, v8::internal::Object**, v8::internal::Isolate*)+0x133) [0x219d105]
    [0x31d91a8043a7]
Command: out/Debug/node /home/sqrt/src/node/test/parallel/test-vm-function-redefinition.js
Member

addaleax replied Jan 29, 2017

@fhinkel fyi, this test fails in debug mode:

Path: parallel/test-vm-function-redefinition
#
# Fatal error in ../deps/v8/src/lookup.h, line 226
# Check failed: has_property_.
#

==== C stack trace ===============================

    out/Debug/node(v8::base::debug::StackTrace::StackTrace()+0x1d) [0x27929ad]
    out/Debug/node(V8_Fatal+0x10b) [0x278f0eb]
    out/Debug/node(v8::internal::LookupIterator::property_details() const+0x3d) [0x166b549]
    out/Debug/node() [0x219c6ca]
    out/Debug/node() [0x219cdd3]
    out/Debug/node() [0x219d2e1]
    out/Debug/node(v8::internal::Runtime_DeclareGlobals(int, v8::internal::Object**, v8::internal::Isolate*)+0x133) [0x219d105]
    [0x31d91a8043a7]
Command: out/Debug/node /home/sqrt/src/node/test/parallel/test-vm-function-redefinition.js
@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Jan 30, 2017

Member

Yikes, OK. Will look into it.

Member

fhinkel replied Jan 30, 2017

Yikes, OK. Will look into it.

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Feb 5, 2017

Member

Fixed in https://codereview.chromium.org/2675993002/. Should we cherry-pick?

Member

fhinkel replied Feb 5, 2017

Fixed in https://codereview.chromium.org/2675993002/. Should we cherry-pick?

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 5, 2017

Member

@fhinkel For now the tests will fail in Debug mode anyway due to #7144, so I don’t think it’s very important?

Member

addaleax replied Feb 5, 2017

@fhinkel For now the tests will fail in Debug mode anyway due to #7144, so I don’t think it’s very important?

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Feb 6, 2017

Member

Without the fix, we're using a variable without initializing it first. But it's an integer that's cast to an enum. So maybe not really dangerous?

Member

fhinkel replied Feb 6, 2017

Without the fix, we're using a variable without initializing it first. But it's an integer that's cast to an enum. So maybe not really dangerous?

Please sign in to comment.