Skip to content

Commit c4d9cdb

Browse files
mhdawsonFishrock123
authored andcommitted
test: allow options for v8 testing
Allow extra options when testing v8 in Node tree PR-URL: #5502 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 2c619f2 commit c4d9cdb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ ifdef ENABLE_V8_TAP
2121
TAP_V8_BENCHMARKS := --junitout v8-benchmarks-tap.xml
2222
endif
2323

24+
V8_TEST_OPTIONS = $(V8_EXTRA_TEST_OPTIONS)
2425
ifdef DISABLE_V8_I18N
25-
V8_TEST_NO_I18N := --noi18n
26+
V8_TEST_OPTIONS += --noi18n
2627
V8_BUILD_OPTIONS += i18nsupport=off
2728
endif
2829

@@ -210,7 +211,7 @@ test-timers-clean:
210211
test-v8:
211212
# note: performs full test unless QUICKCHECK is specified
212213
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
213-
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
214+
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
214215
--no-presubmit \
215216
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
216217
$(TAP_V8)

0 commit comments

Comments
 (0)