Skip to content

Commit db68cec

Browse files
mcollinaaduh95
authored andcommitted
doc: deprecate HTTP/2 priority signaling
Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #58313 Backport-PR-URL: #58542 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent 3b23687 commit db68cec

File tree

2 files changed

+51
-5
lines changed

2 files changed

+51
-5
lines changed

doc/api/deprecations.md

Lines changed: 41 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3597,11 +3597,48 @@ will throw an error in a future version.
35973597

35983598
<!-- md-lint skip-deprecation DEP0191 -->
35993599

3600-
<!-- md-lint skip-deprecation DEP0192 -->
3600+
### DEP0192: `require('node:_tls_common')` and `require('node:_tls_wrap')`
36013601

3602-
<!-- md-lint skip-deprecation DEP0193 -->
3602+
<!-- YAML
3603+
changes:
3604+
- version: REPLACEME
3605+
pr-url: https://github.com/nodejs/node/pull/57643
3606+
description: Documentation-only deprecation.
3607+
-->
3608+
3609+
Type: Documentation-only
3610+
3611+
The `node:_tls_common` and `node:_tls_wrap` modules are deprecated as they should be considered
3612+
an internal nodejs implementation rather than a public facing API, use `node:tls` instead.
3613+
3614+
### DEP0193: `require('node:_stream_*')`
3615+
3616+
<!-- YAML
3617+
changes:
3618+
- version: REPLACEME
3619+
pr-url: https://github.com/nodejs/node/pull/58337
3620+
description: Documentation-only deprecation.
3621+
-->
3622+
3623+
Type: Documentation-only
3624+
3625+
The `node:_stream_duplex`, `node:_stream_passthrough`, `node:_stream_readable`, `node:_stream_transform`,
3626+
`node:_stream_wrap` and `node:_stream_writable` modules are deprecated as they should be considered
3627+
an internal nodejs implementation rather than a public facing API, use `node:stream` instead.
3628+
3629+
### DEP0194: `require('node:http2').Http2Stream.priority`
3630+
3631+
<!-- YAML
3632+
changes:
3633+
- version: REPLACEME
3634+
pr-url: https://github.com/nodejs/node/pull/58313
3635+
description: Documentation-only deprecation.
3636+
-->
3637+
3638+
Type: Documentation-only
36033639

3604-
<!-- md-lint skip-deprecation DEP0194 -->
3640+
The support for priority signaling has been deprecated in the [RFC 9113][], and
3641+
will be removed in future versions of Node.js.
36053642

36063643
<!-- md-lint skip-deprecation DEP0195 -->
36073644

@@ -3625,6 +3662,7 @@ Creating SHAKE-128 and SHAKE-256 digests without an explicit `options.outputLeng
36253662
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
36263663
[RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
36273664
[RFC 8247 Section 2.4]: https://www.rfc-editor.org/rfc/rfc8247#section-2.4
3665+
[RFC 9113]: https://datatracker.ietf.org/doc/html/rfc9113#section-5.3.1
36283666
[WHATWG URL API]: url.md#the-whatwg-url-api
36293667
[`"exports"` or `"main"` entry]: packages.md#main-entry-point-export
36303668
[`'uncaughtException'`]: process.md#event-uncaughtexception

doc/api/http2.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1457,6 +1457,7 @@ numeric stream identifier.
14571457

14581458
<!-- YAML
14591459
added: v8.4.0
1460+
deprecated: REPLACEME
14601461
-->
14611462

14621463
* `options` {Object}
@@ -1474,6 +1475,9 @@ added: v8.4.0
14741475

14751476
Updates the priority for this `Http2Stream` instance.
14761477

1478+
The support for priority signaling has been deprecated in the [RFC 9113][], and
1479+
will be removed in future versions of Node.js.
1480+
14771481
#### `http2stream.rstCode`
14781482

14791483
<!-- YAML
@@ -1583,8 +1587,11 @@ Provides miscellaneous information about the current state of the
15831587
remotely.
15841588
* `sumDependencyWeight` {number} The sum weight of all `Http2Stream`
15851589
instances that depend on this `Http2Stream` as specified using
1586-
`PRIORITY` frames.
1587-
* `weight` {number} The priority weight of this `Http2Stream`.
1590+
`PRIORITY` frames. This has been **deprecated** in [RFC 9113][], and
1591+
support for it will be removed in future versions of Node.js.
1592+
* `weight` {number} The priority weight of this `Http2Stream`. This has been
1593+
**deprecated** in [RFC 9113][], and support for it will be removed in future
1594+
versions of Node.js.
15881595

15891596
A current state of this `Http2Stream`.
15901597

@@ -4866,6 +4873,7 @@ you need to implement any fall-back behavior yourself.
48664873
[RFC 7838]: https://tools.ietf.org/html/rfc7838
48674874
[RFC 8336]: https://tools.ietf.org/html/rfc8336
48684875
[RFC 8441]: https://tools.ietf.org/html/rfc8441
4876+
[RFC 9113]: https://datatracker.ietf.org/doc/html/rfc9113#section-5.3.1
48694877
[Sensitive headers]: #sensitive-headers
48704878
[`'checkContinue'`]: #event-checkcontinue
48714879
[`'connect'`]: #event-connect

0 commit comments

Comments
 (0)