Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: register the inspector async hooks in bootstrap/node.js #25443

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Jan 11, 2019

So it's easier to tell the side effects of this setup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
process: register the inspector async hooks in bootstrap/node.js
So it's easier to tell the side effects of this setup.
@lpinca
lpinca approved these changes Jan 12, 2019
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

Re-run of failing node-test-commit-arm
Re-run of failing node-test-commit-windows-fanned

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Landed in 6b2af91

joyeecheung added a commit that referenced this pull request Jan 16, 2019
process: register the inspector async hooks in bootstrap/node.js
So it's easier to tell the side effects of this setup.

PR-URL: #25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 16, 2019
process: register the inspector async hooks in bootstrap/node.js
So it's easier to tell the side effects of this setup.

PR-URL: #25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
process: register the inspector async hooks in bootstrap/node.js
So it's easier to tell the side effects of this setup.

PR-URL: nodejs#25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
process: register the inspector async hooks in bootstrap/node.js
So it's easier to tell the side effects of this setup.

PR-URL: nodejs#25443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.