New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/util: use internal/errors.js #11301

Closed
wants to merge 1 commit into
base: master
from

Conversation

@seppevs
Contributor

seppevs commented Feb 10, 2017

Change internal/util.js so it makes use of the new internal/errors.js module.

See #11273 for more info.

cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

error

@jasnell jasnell referenced this pull request Feb 10, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
Show outdated Hide outdated test/parallel/test-internal-errors.js Outdated
Show outdated Hide outdated test/parallel/test-internal-errors.js Outdated
Show outdated Hide outdated lib/internal/errors.js Outdated
@joyeecheung

This comment has been minimized.

Show comment
Hide comment

@jasnell jasnell added the blocked label Apr 5, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 1, 2017

Member

We're finally able to move forward on this, but it's going to need a rebase

Member

jasnell commented May 1, 2017

We're finally able to move forward on this, but it's going to need a rebase

@seppevs

This comment has been minimized.

Show comment
Hide comment
@seppevs

seppevs May 1, 2017

Contributor

Rebase done

Contributor

seppevs commented May 1, 2017

Rebase done

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
Member

joyeecheung commented May 2, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 2, 2017

Member

@nodejs/ctc ... this is ready to go, but as a semver-major needs another CTC member to sign off

Member

jasnell commented May 2, 2017

@nodejs/ctc ... this is ready to go, but as a semver-major needs another CTC member to sign off

@Trott

Trott approved these changes May 2, 2017

LGTM modulo textual nits and assuming CI is green.

Show outdated Hide outdated doc/api/errors.md Outdated
Show outdated Hide outdated lib/internal/errors.js Outdated
@seppevs

This comment has been minimized.

Show comment
Hide comment
@seppevs

seppevs May 3, 2017

Contributor

Changes done

Contributor

seppevs commented May 3, 2017

Changes done

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 24, 2017

Member

@jasnell Should the blocked label be removed?

Member

Trott commented May 24, 2017

@jasnell Should the blocked label be removed?

@jasnell jasnell removed the blocked label May 24, 2017

Show outdated Hide outdated test/parallel/test-internal-util-assertCrypto.js Outdated
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 14, 2017

Member

@seppevs Please fix @jasnell's annotation (#11301 (comment)) and resolve the conflicts.

Member

tniessen commented Jun 14, 2017

@seppevs Please fix @jasnell's annotation (#11301 (comment)) and resolve the conflicts.

Show outdated Hide outdated doc/api/errors.md Outdated
@seppevs

This comment has been minimized.

Show comment
Hide comment
@seppevs

seppevs Jun 15, 2017

Contributor

Changes done

Contributor

seppevs commented Jun 15, 2017

Changes done

Show outdated Hide outdated doc/api/errors.md Outdated
@tniessen

This comment has been minimized.

Show comment
Hide comment

@tniessen tniessen self-assigned this Jun 15, 2017

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 15, 2017

Member

Landed in de4a749, thank you! 🎉

Member

tniessen commented Jun 15, 2017

Landed in de4a749, thank you! 🎉

@tniessen tniessen closed this Jun 15, 2017

tniessen added a commit that referenced this pull request Jun 15, 2017

internal/util: use internal/errors.js
PR-URL: #11301
Refs: #11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <fhinkel@vt.edu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment