Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add hasCrypto check to test-cli-node-options #12692

Closed

Conversation

@danbev
Copy link
Member

commented Apr 27, 2017

Currently when configure --without-ssl the test will throw the following
error:

bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.
@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2017

@mscdex mscdex added the cli label Apr 27, 2017

@lpinca
lpinca approved these changes Apr 27, 2017
@sam-github

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

@nodejs/testing @nodejs/build We need a CI job, probably linux-only would be fine, that does a configure and test without SSL. This fix is only one of a string of fixes that have been made for this. Its really hard to remember such an obscure build case, sorry @danbev

@gibfahn

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

@sam-github it's on my list... nodejs/build#643

I'm thinking that another job that runs a variety of targets with different configurations would probably be useful, (we need --without-intl as well)

danbev added a commit to danbev/node that referenced this pull request Apr 29, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2017

Landed in 427cd29

@danbev danbev closed this Apr 29, 2017

@danbev danbev deleted the danbev:add-has-crypto-check-cli-node-options branch Apr 30, 2017

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should land with #12677

sam-github added a commit to sam-github/node that referenced this pull request Jul 10, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Jul 24, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Jul 24, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Sep 25, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Sep 25, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Oct 5, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Oct 10, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Oct 10, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Oct 10, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
sam-github added a commit to sam-github/node that referenced this pull request Oct 11, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
MylesBorins added a commit that referenced this pull request Oct 16, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

Backport-PR-URL: #12677
PR-URL: #12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
@MylesBorins MylesBorins referenced this pull request Oct 17, 2017
MylesBorins added a commit that referenced this pull request Oct 25, 2017
test: add hasCrypto check to test-cli-node-options
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

Backport-PR-URL: #12677
PR-URL: #12692
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
@MylesBorins MylesBorins referenced this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.