Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
util: introduce `util.types.is[…]` type checks #18415
Provide public APIs for native typechecking that is actually useful. The motivation for this is providing alternatives to userland modules that would currently rely on
This is based off the list in
Also, for context, previous efforts:
Affected core subsystem(s)
evanlucas left a comment
LGTM with a few nits. Are we sure we want to put this on util as opposed to a new module?
I would lean more towards a types module, but am fine either way. Thanks for doing this!!
referenced this pull request
Jan 28, 2018
Maybe it is due to big diff, but some old review comments are not hidden now and are associated with the wrong lines, so do not be confused: