Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: make async iterator .next() always resolve #24668

Closed
wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

commented Nov 27, 2018

See: nodejs/readable-stream#387

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Nov 27, 2018

@mcollina sadly an error occured when I tried to trigger a build :(

@reconbot
Copy link
Contributor

left a comment

test/parallel/test-stream-readable-async-iterators.js Outdated Show resolved Hide resolved

@mcollina mcollina force-pushed the mcollina:stream-iterator-fix branch from be46937 to 4fea207 Nov 29, 2018

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2018

}
assert.strictEqual(e, err);
})()]);
})();

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Nov 29, 2018

Member

Nit: the Promise.all should be obsolete.


const b = r[Symbol.asyncIterator]();
const c = b.next();
const d = b.next();

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Nov 29, 2018

Member

Suggestion: verify that c and d are not done yet.

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2018

Landed in fa1535a

@mcollina mcollina closed this Nov 29, 2018

@mcollina mcollina deleted the mcollina:stream-iterator-fix branch Nov 29, 2018

pull bot pushed a commit to SimenB/node that referenced this pull request Nov 29, 2018
stream: make async iterator .next() always resolve
See: nodejs/readable-stream#387

PR-URL: nodejs#24668
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Nov 29, 2018
stream: make async iterator .next() always resolve
See: nodejs/readable-stream#387

PR-URL: #24668
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
stream: make async iterator .next() always resolve
See: nodejs/readable-stream#387

PR-URL: nodejs#24668
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
stream: make async iterator .next() always resolve
See: nodejs/readable-stream#387

PR-URL: #24668
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
stream: make async iterator .next() always resolve
See: nodejs/readable-stream#387

PR-URL: #24668
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.