Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit and simplify util.inspect() docs #25195

Merged
merged 1 commit into from Dec 31, 2018

Conversation

@cjihrig
Copy link
Contributor

commented Dec 23, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
@lpinca
lpinca approved these changes Dec 24, 2018

@cjihrig cjihrig force-pushed the cjihrig:doc branch from a23362c to 059182c Dec 27, 2018

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

@Trott, I've updated this PR with your suggestions.

@BridgeAR
Copy link
Member

left a comment

Overall LGTM, just a few suggestions.

doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved

@cjihrig cjihrig force-pushed the cjihrig:doc branch from 059182c to 481e11f Dec 31, 2018

doc: edit and simplify util.inspect() docs
PR-URL: #25195
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@cjihrig cjihrig force-pushed the cjihrig:doc branch from 481e11f to 3c5e237 Dec 31, 2018

@cjihrig cjihrig merged commit 3c5e237 into nodejs:master Dec 31, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:doc branch Dec 31, 2018

targos added a commit that referenced this pull request Jan 1, 2019
doc: edit and simplify util.inspect() docs
PR-URL: #25195
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: edit and simplify util.inspect() docs
PR-URL: nodejs#25195
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.