Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: use kHandle symbol for accessing native handle #26491

Closed
wants to merge 1 commit into from
Closed

net: use kHandle symbol for accessing native handle #26491

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 7, 2019

Use a common kHandle for all StreamBase-based streams.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
net: use kHandle symbol for accessing native handle
fcaa459 
Use a common `kHandle` for all `StreamBase`-based streams.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2797/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. net Issues and PRs related to the net subsystem. labels Mar 7, 2019
sam-github
sam-github approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm surprised that the req.stream property was unused and could be deleted.

@addaleax
Copy link
Member Author

addaleax commented Mar 7, 2019

@sam-github Yeah, me too – I don’t think it’s conceptually necessary though, because req.handle[owner_symbol] should also point back to the original Http2Stream?

@sam-github
Copy link
Contributor

I'm fuzzy on the concept, but if tests pass, its not needed. Not just HTTP2, owner_symbol is also what lib/_tls_wrap.js uses to get back to the stream.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21332/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@addaleax
Copy link
Member Author

addaleax commented Mar 9, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/21368/ ✔️

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 9, 2019
@addaleax @BridgeAR
net: use kHandle symbol for accessing native handle
e7f5886 
Use a common `kHandle` for all `StreamBase`-based streams.

PR-URL: nodejs#26491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 9, 2019

Landed in e7f5886 🎉

@BridgeAR BridgeAR closed this Mar 9, 2019
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@addaleax @BridgeAR
net: use kHandle symbol for accessing native handle
9ed0624 
Use a common `kHandle` for all `StreamBase`-based streams.

PR-URL: #26491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@addaleax @BridgeAR
net: use kHandle symbol for accessing native handle
84de418 
Use a common `kHandle` for all `StreamBase`-based streams.

PR-URL: nodejs#26491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@addaleax @BridgeAR
net: use kHandle symbol for accessing native handle
c14aa07 
Use a common `kHandle` for all `StreamBase`-based streams.

PR-URL: #26491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@addaleax @nodejs-github-bot @sam-github @BridgeAR @jasnell @lpinca @cjihrig @joyeecheung @mihalskiy