Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.2.0 release proposal #40983

Merged
merged 110 commits into from
Nov 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
51ac59b
build: add GitHub Action to update tools modules
Trott Oct 29, 2021
30623c2
tools: improve update scripts
Trott Oct 30, 2021
dc9e688
test: add semicolons for linter update
Trott Nov 4, 2021
5b08e90
tools: update babel-eslint-parser to 7.16.0
Trott Nov 4, 2021
429915a
doc: add initial list of technical priorities
mhdawson Sep 27, 2021
2536be7
meta: update AUTHORS
nodejs-github-bot Nov 7, 2021
75288fb
doc: fix order of announce work
mhdawson Nov 4, 2021
20d7d65
doc: clarify getAuthTag with authTagLength
tniessen Nov 3, 2021
8e52563
deps: update ICU to 70.1
targos Oct 29, 2021
9271f23
doc: update maintaining ICU guide
targos Oct 29, 2021
d3070d8
doc: fix corepack grammar for `--force` flag
styfle Nov 8, 2021
80ce97f
http: change totalSocketCount only on socket creation/close
jodevsa Oct 24, 2021
924d29e
src: add and fix some preprocessor comments
tniessen Nov 2, 2021
0de2850
src: add x509.fingerprint512 to crypto module
Aug 30, 2021
5ceb06c
doc: fix linter-enforced formatting in crypto.md
VoltrexKeyva Nov 10, 2021
3d89623
test: fix flaky test-policy-integrity
Trott Nov 8, 2021
9711ccf
deps: upgrade npm to 8.1.3
npm-robot Nov 4, 2021
7f5931d
crypto: fix build without scrypt
shr-project Oct 26, 2021
8166b07
doc: fix transform stream example
evanlucas Nov 10, 2021
bddb4c6
http: add missing initialization
mhdawson Oct 21, 2021
a5a1691
fs: nullish coalescing to respect zero positional reads
mihilmy Nov 3, 2021
3be49d6
src: prevent extra copies of `TimerWrap::TimerCb`
RaisinTen Nov 12, 2021
415b42f
src,crypto: refactor `crypto_tls.*`
RaisinTen Nov 12, 2021
0691649
async_hooks: expose async_wrap providers
RafaelGSS Nov 12, 2021
10a842d
lib: fix typos in lib code comments
kuriyosh Nov 12, 2021
727b34e
tools: only validate first commit message of a PR
aduh95 Nov 12, 2021
82b4226
src,crypto: remove `AllocatedBuffer`s from `crypto_spkac`
RaisinTen Nov 13, 2021
4a971f6
async_hooks: eliminate require side effects
Nov 10, 2021
2ea08e9
doc: claim ABI version for Electron 18
VerteDinde Nov 13, 2021
7c4f9a3
stream: allow calling callback before promise
ronag Nov 10, 2021
c91a9ab
doc: tweak guidance for modules in core
mhdawson Oct 25, 2021
e451ec9
meta: edit GOVERNANCE.md for minor updates
Trott Nov 13, 2021
7d127d2
stream: fix non readable Duplex readableAborted
ronag Nov 13, 2021
2979c58
crypto: throw errors in SignTraits::DeriveBits
tniessen Nov 15, 2021
150c0f1
test: add tests for invalid UTF-8
git-srinivas Oct 23, 2021
813cf74
meta: update AUTHORS
nodejs-github-bot Nov 14, 2021
fa37428
deps: add -fno-strict-aliasing flag to libuv
danbev Nov 16, 2021
88b57bc
src,doc: add SyntaxError napi support
Nov 6, 2021
3a4f387
process: support hrtime in the snapshot
joyeecheung Jul 9, 2021
a8cc8b6
crypto: trim input for NETSCAPE_SPKI_b64_decode
codebytere Nov 8, 2021
c2259c9
src: reset error struct if error code is napi_ok
JckXia Oct 21, 2021
896073b
test: deflake child-process-pipe-dataflow
lpinca Nov 17, 2021
fe2cd09
doc: fix `added:` info for `Readable.fromWeb()`
lpinca Nov 15, 2021
16ee842
stream: pipeline should drain empty readable
ronag Oct 29, 2021
43e8650
test: add AsyncLocalStorage tests using udp, tcp and tls sockets
RaisinTen Nov 13, 2021
b614b17
Revert "lib: use helper for readability"
RaisinTen Nov 13, 2021
48157c4
Revert "async_hooks: merge resource_symbol with owner_symbol"
RaisinTen Nov 13, 2021
dfc6fc9
meta: update name and email
null8626 Nov 18, 2021
9c200e1
doc: add pref to using draft PR versus WIP label
mhdawson Nov 19, 2021
e793331
build: fix tools.yml errors
Trott Nov 19, 2021
dfdf68f
doc: improve README.md lede section
Trott Nov 19, 2021
4c47b01
doc: document optional params in napi_get_cb_info
mhdawson Nov 15, 2021
b46184d
deps: update to uvwasi 0.0.12
cjihrig Nov 20, 2021
de4d018
tools: update @babel/eslint-parser to 7.16.3
nodejs-github-bot Nov 20, 2021
694012b
doc: define "types", "deno" community conditions
guybedford Nov 3, 2021
c485460
test: use descriptive name for destination file
lpinca Nov 17, 2021
b190b0e
test: deflake http2-pipe-named-pipe
lpinca Nov 17, 2021
522a30f
test: fix argument order in assertion
lpinca Nov 17, 2021
a612ecb
deps: V8: cherry-pick 7ae0b77628f6
rayw000 Nov 19, 2021
6506a42
deps: V8: cherry-pick cced52a97ee9
rayw000 Nov 21, 2021
371ee64
deps: update V8 to 9.6.180.14
targos Nov 21, 2021
69de8c8
build: reset embedder string to "-node.0"
targos Nov 21, 2021
1ff83c4
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
29a6e15
deps: V8: patch register-arm64.h
refack May 22, 2019
d6e5dd5
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
eab5ef5
deps: make v8.h compatible with VS2015
joaocgreis Sep 22, 2021
82a8736
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
9ecf4be
deps: silence irrelevant V8 warning
targos Jan 30, 2021
dfb97fb
deps: silence irrelevant V8 warning
targos May 1, 2021
37c9828
deps: disable trap handler for Windows cross-compiler
targos Oct 20, 2021
94acaae
deps: V8: patch jinja2 for Python 3.10 compat
targos Oct 5, 2021
e60053d
deps: V8: cherry-pick 2a0bc36dec12
targos Oct 11, 2021
d6ae50f
deps: V8: cherry-pick 7ae0b77628f6
rayw000 Nov 19, 2021
d461603
deps: V8: cherry-pick cced52a97ee9
rayw000 Nov 21, 2021
e3f8988
tools: update V8 gypfiles for 9.6
targos Oct 20, 2021
d97ad30
tools: disable trap handler for Windows cross-compiler
targos Oct 20, 2021
878ba91
tools: add find-inactive-tsc
Trott Nov 21, 2021
009ab4d
test: deflake fs-promises-watch
lpinca Nov 21, 2021
4288c6a
test: deflake cluster-concurrent-disconnect
lpinca Nov 21, 2021
1482c44
build: fix `make` invocation in tools.yml
Trott Nov 22, 2021
90f35fc
deps: upgrade npm to 8.1.4
npm-robot Nov 18, 2021
534409d
stream: fix finished regression when working with legacy Stream
mcollina Nov 22, 2021
650c9bd
stream: pipeline with end option
ronag Nov 19, 2021
e674f61
tools: update ESLint to 8.3.0
lpinca Nov 22, 2021
3d593aa
tools: update lint-md dependencies
Trott Nov 22, 2021
cf495a6
doc: clarify more optional parameters in node-api
mhdawson Nov 19, 2021
05d652a
build: fix branch name for lint-md-dependencies update
Trott Nov 22, 2021
ae12a60
test: improve test coverage of readline/promises
kuriyosh Nov 23, 2021
22265e3
tools: update lint-md-dependencies to rollup@2.60.1
nodejs-github-bot Nov 22, 2021
9c897b6
meta: update AUTHORS
nodejs-github-bot Nov 21, 2021
62171eb
test: mark test-fs-watch-non-recursive flaky on Windows
lpinca Nov 23, 2021
675c210
lib: add reason to AbortSignal
jasnell Nov 13, 2021
b92416f
doc: fix spelling of 'WebAssembly'
GeoffreyBooth Nov 10, 2021
3c8aa21
module: import assertions improvements
GeoffreyBooth Nov 10, 2021
0201f3f
tools: ping TSC members identified as inactive
Trott Nov 24, 2021
1555dbd
repl: fix and extend require/import tab complete
Mesteery Nov 25, 2021
acbd822
src,crypto: use `ByteSource::ToBuffer()` in `crypto_dh`
RaisinTen Nov 25, 2021
65b33ba
build: remove extraneous quotation marks from commit body
Trott Nov 25, 2021
dc99ae3
stream: fix the ReadableStreamBYOBReader error message
jasnell Nov 18, 2021
6e9b665
doc: remove experimental abortcontroller flag
iam-frankqiu Oct 27, 2021
6ebbd0d
tools: fix commit-lint GH Actions CI
aduh95 Nov 17, 2021
130777a
doc: update BUILDING.md section on running tests
Trott Nov 25, 2021
747247b
tools: update gyp-next to v0.10.1
targos Nov 26, 2021
3ec78d1
meta: add feature request label for issue template
Mesteery Nov 26, 2021
fa9b5c3
stream: deprecate thenable support
aduh95 Nov 26, 2021
8966ab3
doc: improve grammar in API description
tniessen Nov 26, 2021
3bfc9f5
doc: add information on suppressing initial break in debugger
Trott Nov 26, 2021
86d1c0b
stream: drain Transform with 0 highWaterMark
ronag Nov 24, 2021
70bd90e
stream: stricter isReadableNodeStream
ronag Nov 26, 2021
1aaa4eb
2021-11-30, Version 17.2.0 (Current)
targos Nov 26, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/2-feature-request.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: "\U0001F680 Feature request"
about: Suggest an idea for this project

labels: feature request
---

<!--
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Commit messages adheres to guidelines at https://goo.gl/p2fr5Q"
name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q"

on: [pull_request]

Expand All @@ -11,15 +11,18 @@ jobs:
steps:
- name: Compute number of commits in the PR
id: nb-of-commits
run: echo "::set-output name=nb::$((${{ github.event.pull_request.commits }} + 1))"
run: |
echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
- uses: actions/checkout@v2
with:
fetch-depth: ${{ steps.nb-of-commits.outputs.nb }}
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit messages
- name: Validate commit message
run: |
echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
git log --oneline -${{ github.event.pull_request.commits }} HEAD^ | awk '{ if ($2 != "fixup!" && $2 != "squash!") { print $1 } }' | xargs npx -q core-validate-commit --no-validate-metadata --tap
git rev-parse HEAD~${{ steps.nb-of-commits.outputs.minusOne }} | xargs npx -q core-validate-commit --no-validate-metadata --tap
6 changes: 3 additions & 3 deletions .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ name: Find inactive collaborators

on:
schedule:
# Run on the 15th day of the month at 4:05 AM UTC.
- cron: '5 4 15 * *'
# Run every Monday at 4:05 AM UTC.
- cron: '5 4 * * 1'

workflow_dispatch:

env:
NODE_VERSION: 16.x
NODE_VERSION: lts/*
NUM_COMMITS: 5000

jobs:
Expand Down
52 changes: 52 additions & 0 deletions .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: Find inactive TSC members

on:
schedule:
# Run every Tuesday 12:05 AM UTC.
- cron: '5 0 * * 2'

workflow_dispatch:

env:
NODE_VERSION: lts/*

jobs:
find:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest

steps:
- name: Checkout the repo
uses: actions/checkout@v2

- name: Clone nodejs/TSC repository
uses: actions/checkout@v2
with:
fetch-depth: 0
repository: nodejs/TSC
path: .tmp

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}

- name: Find inactive TSC members
run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV

- name: Open pull request
uses: gr2m/create-or-update-pull-request-action@v1
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
author: Node.js GitHub Bot <github-bot@iojs.org>
branch: actions/inactive-tsc
body: |
This PR was generated by tools/find-inactive-tsc.yml.

@nodejs/tsc ${{ env.INACTIVE_TSC_HANDLES }}

${{ env.DETAILS_FOR_COMMIT_BODY }}
commit-message: "meta: move one or more TSC members to emeritus"
labels: meta
title: "meta: move one or more TSC members to emeritus"
63 changes: 63 additions & 0 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: "tools update"
on:
schedule:
# Run once a week at 00:05 AM UTC on Saturday.
- cron: '5 0 * * 6'

workflow_dispatch:

jobs:
tools_update:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
strategy:
fail-fast: false # Prevent other jobs from aborting if one fails
matrix:
include:
- id: eslint
run: |
cd tools
NEW_VERSION=$(npm view eslint dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./node_modules/eslint/package.json').version")
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./update-eslint.sh
fi
- id: "@babel/eslint-parser"
run: |
cd tools
NEW_VERSION=$(npm view @babel/eslint-parser dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./node_modules/@babel/eslint-parser/package.json').version")
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./update-babel-eslint.sh
fi
- id: "lint-md-dependencies"
run: |
cd tools/lint-md
npm ci
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
if [ "$NEW_VERSION" != "" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
rm -rf package-lock.json node_modules
# Include $NEW_VERSION to explicitly update the package.json
# entry for the dependency and also so that semver-major updates
# are not skipped.
npm install --ignore-scripts $NEW_VERSION
npm install --ignore-scripts
cd ../..
make lint-md-rollup
fi
steps:
- uses: actions/checkout@v2
- run: ${{ matrix.run }}
- uses: gr2m/create-or-update-pull-request-action@v1 # Create a PR or update the Action's existing PR
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
author: Node.js GitHub Bot <github-bot@iojs.org>
body: "This is an automated update of ${{ matrix.id }} to ${{ env.NEW_VERSION }}."
branch: "actions/tools-update-${{ matrix.id }}" # Custom branch *just* for this Action.
commit-message: "tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}"
labels: tools
title: "tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}"
6 changes: 5 additions & 1 deletion .mailmap
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
3nprob <git@3n.anonaddy.com> <3nprob@3nprob>
Aaron Bieber <aaron@bolddaemon.com> <deftly@gmail.com>
Aaron Heckmann <aaron.heckmann@gmail.com> <aaron.heckmann+github@gmail.com>
Aayush Ahuja <aayush.a@directi.com>
Expand Down Expand Up @@ -340,6 +341,8 @@ Miroslav Bajtoš <oss@bajtos.net> <miro.bajtos@gmail.com>
Miroslav Bajtoš <oss@bajtos.net> <miroslav@strongloop.com>
Mitar Milutinovic <mitar.git@tnode.com>
Mithun Sasidharan <mithunsasidharan89@gmail.com> <msasidharan@paypal.com>
Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> <62040526+VoltrexMaster@users.noreply.github.com>
Myles Borins <myles.borins@gmail.com> <mborins@us.ibm.com>
Myles Borins <myles.borins@gmail.com> <mylesborins@github.com>
Myles Borins <myles.borins@gmail.com> <mylesborins@google.com>
Expand Down Expand Up @@ -430,6 +433,7 @@ Shiya Luo <luo.shiya@gmail.com>
Shobhit Chittora <chittorashobhit@gmail.com> <schittora@paypal.com>
Siddharth Mahendraker <siddharth_mahen@hotmail.com> <siddharth_mahen@me.com>
Simon Willison <simon@simonwillison.net>
Simone Busoli <simone.busoli@nearform.com> <simone.busoli@gmail.com>
Siobhan O'Donovan <siobhan@justshiv.com>
Siyuan Gao <siyuangao@gmail.com>
solebox <solekiller@gmail.com> <5013box@gmail.com>
Expand Down Expand Up @@ -498,10 +502,10 @@ Tyler Larson <talltyler@gmail.com>
Ujjwal Sharma <ryzokuken@disroot.org> <ryzokuken@igalia.com>
Ujjwal Sharma <ryzokuken@disroot.org> <usharma1998@gmail.com>
Uttam Pawar <upawar@gmail.com> <uttam.c.pawar@intel.com>
Viero Fernando <vierofernando9@gmail.com> <60427892+vierofernando@users.noreply.github.com>
Viktor Karpov <viktor.s.karpov@gmail.com>
Vincent Voyer <v@fasterize.com>
Vladimir de Turckheim <vlad2t@hotmail.com>
Voltrex <mohammadkeyvanzade94@gmail.com> <62040526+VoltrexMaster@users.noreply.github.com>
vsemozhetbyt <vsemozhetbyt@gmail.com>
Vyacheslav Egorov <vegorov@chromium.org>
Wang Xinyong <wang.xy.chn@gmail.com> <wangxy.chn@gmail.com>
Expand Down
14 changes: 12 additions & 2 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -3249,7 +3249,7 @@ Darkripper214 <phakorn214@gmail.com>
Anu Pasumarthy <anupama.pasumarthy@gmail.com>
HiroyukiYagihashi <hey@hiroy.uk>
Arkerone <shaita.axel@gmail.com>
Voltrex <mohammadkeyvanzade94@gmail.com>
Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ycjcl868 <45808948@qq.com>
Serkan Özel <serkanozel380@gmail.com>
Ferdi <iguessitsokaythen@gmail.com>
Expand Down Expand Up @@ -3324,7 +3324,7 @@ Node.js GitHub Bot <github-bot@iojs.org>
Alexey Ten <alexeyten@gmail.com>
JckXia <ys3xia@uwaterloo.ca>
Christian Boehlke <christian@boehlkes.de>
null <60427892+vierofernando@users.noreply.github.com>
Viero Fernando <vierofernando9@gmail.com>
Dominic Elm <elmdominic@gmx.net>
treysis <treysis@gmx.net>
shfshanyue <xianger94@gmail.com>
Expand Down Expand Up @@ -3360,5 +3360,15 @@ simon-id <simon.id@protonmail.com>
Francesco Trotta <github@fasttime.org>
Richie Bendall <richiebendall@gmail.com>
ryan <chai_xb@163.com>
Piotr Rybak <rybak.piotr@yahoo.com>
Jean Burellier <sheplu@users.noreply.github.com>
Subhi Al Hasan <subhialhasan@protonmail.com>
3nprob <git@3n.anonaddy.com>
Martin Jansa <martin.jansa@lge.com>
Omar El-Mihilmy <mihilmy@yahoo.com>
Yoshiki <yosyos0306@gmail.com>
Keeley Hammond <vertedinde@electronjs.org>
git-srinivas <vykuntamsrinivas@gmail.com>
Idan Attias <idana@wix.com>

# Generated by tools/update-authors.js
32 changes: 17 additions & 15 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ platforms. This is true regardless of entries in the table below.
community will only address issues that reproduce on native GNU/Linux
systems. Issues that only reproduce on WSL should be reported in the
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
Windows binary (`node.exe`) in WSL is not recommended. It will not work
without workarounds such as stdio redirection.
Windows binary (`node.exe`) in WSL will not work without workarounds such as
stdio redirection.

[^6]: Running Node.js on x86 Windows should work and binaries
are provided. However, tests in our infrastructure only run on WoW64.
Expand Down Expand Up @@ -306,8 +306,7 @@ $ make test-only

At this point, you are ready to make code changes and re-run the tests.

If you are running tests before submitting a pull request, the recommended
command is:
If you are running tests before submitting a pull request, use:

```console
$ make -j4 test
Expand All @@ -316,31 +315,34 @@ $ make -j4 test
`make -j4 test` does a full check on the codebase, including running linters and
documentation tests.

Make sure the linter does not report any issues and that all tests pass. Please
do not submit patches that fail either check.

If you want to run the linter without running tests, use
To run the linter without running tests, use
`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.

If you are updating tests and want to run tests in a single test file
(e.g. `test/parallel/test-stream2-transform.js`):

```text
$ python tools/test.py test/parallel/test-stream2-transform.js
$ tools/test.py test/parallel/test-stream2-transform.js
```

You can execute the entire suite of tests for a given subsystem
by providing the name of a subsystem:

```text
$ python tools/test.py -J --mode=release child-process
$ tools/test.py -J child-process
```

You can also execute the tests in a tests directory (such as `test/message`):

```text
$ tools/test.py -J test/message
```

If you want to check the other options, please refer to the help by using
the `--help` option:

```text
$ python tools/test.py --help
$ tools/test.py --help
```

You can usually run tests directly with node:
Expand All @@ -355,7 +357,7 @@ the `lib` or `src` directories.
The tests attempt to detect support for IPv6 and exclude IPv6 tests if
appropriate. If your main interface has IPv6 addresses, then your
loopback interface must also have '::1' enabled. For some default installations
on Ubuntu that does not seem to be the case. To enable '::1' on the
on Ubuntu, that does not seem to be the case. To enable '::1' on the
loopback interface on Ubuntu:

```bash
Expand All @@ -364,7 +366,7 @@ sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0

You can use
[node-code-ide-configs](https://github.com/nodejs/node-code-ide-configs)
to run/debug tests, if your IDE configs are present.
to run/debug tests if your IDE configs are present.

#### Running coverage

Expand Down Expand Up @@ -392,7 +394,7 @@ If you are updating tests and want to collect coverage for a single test file

```text
$ make coverage-clean
$ NODE_V8_COVERAGE=coverage/tmp python tools/test.py test/parallel/test-stream2-transform.js
$ NODE_V8_COVERAGE=coverage/tmp tools/test.py test/parallel/test-stream2-transform.js
$ make coverage-report-js
```

Expand All @@ -401,7 +403,7 @@ by providing the name of a subsystem:

```text
$ make coverage-clean
$ NODE_V8_COVERAGE=coverage/tmp python tools/test.py -J --mode=release child-process
$ NODE_V8_COVERAGE=coverage/tmp tools/test.py -J --mode=release child-process
$ make coverage-report-js
```

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V17.md#17.1.0">17.1.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V17.md#17.2.0">17.2.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V17.md#17.1.0">17.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V17.md#17.0.1">17.0.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V17.md#17.0.0">17.0.0</a><br/>
</td>
Expand Down
7 changes: 3 additions & 4 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ See:
* Participation in working groups
* Merging pull requests

The TSC can remove inactive collaborators or provide them with _Emeritus_
The TSC can remove inactive collaborators or provide them with _emeritus_
status. Emeriti may request that the TSC restore them to active status.

## Technical Steering Committee
Expand All @@ -87,9 +87,8 @@ Charter need approval by the OpenJS Foundation Cross-Project Council (CPC).

### TSC meetings

The TSC meets in a voice conference call. Each year, the TSC elects a chair to
run the meetings. The TSC streams its meetings for public viewing on YouTube or
a similar service.
The TSC meets in a video conference call. Each year, the TSC elects a chair to
run the meetings. The TSC streams its meetings for public viewing on YouTube.

The TSC agenda includes issues that are at an impasse. The intention of the
agenda is not to review or approve all patches. Collaborators review and approve
Expand Down
Loading