Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.2.0 release proposal #40983

Merged
merged 110 commits into from
Nov 30, 2021
Merged

v17.2.0 release proposal #40983

merged 110 commits into from
Nov 30, 2021

Commits on Nov 21, 2021

  1. build: add GitHub Action to update tools modules

    Update ESLint, Babel, remark, and so on. Run once a week.
    
    PR-URL: #40644
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    51ac59b View commit details
    Browse the repository at this point in the history
  2. tools: improve update scripts

    The --production flag has no effect in this situation. Remove it.
    
    Add --ignore-scripts as a precaution.
    
    PR-URL: #40644
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    30623c2 View commit details
    Browse the repository at this point in the history
  3. test: add semicolons for linter update

    Add missing semicolons that will be flagged when we update
    @babel/eslint-parser to 7.16.0.
    
    PR-URL: #40720
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    dc9e688 View commit details
    Browse the repository at this point in the history
  4. tools: update babel-eslint-parser to 7.16.0

    PR-URL: #40720
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    5b08e90 View commit details
    Browse the repository at this point in the history
  5. doc: add initial list of technical priorities

    Co-authored-by: Jean Burellier <sheplu@users.noreply.github.com>
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40235
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    mhdawson authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    429915a View commit details
    Browse the repository at this point in the history
  6. meta: update AUTHORS

    PR-URL: #40748
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    nodejs-github-bot authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    2536be7 View commit details
    Browse the repository at this point in the history
  7. doc: fix order of announce work

    - Since we now just reference the nodejs blog post in the
      post to the nodejs-sec mailing list, change the order
      so the blog post comes first
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40725
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mhdawson authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    75288fb View commit details
    Browse the repository at this point in the history
  8. doc: clarify getAuthTag with authTagLength

    Refs: #40272
    Refs: #20235
    
    PR-URL: #40713
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    20d7d65 View commit details
    Browse the repository at this point in the history
  9. deps: update ICU to 70.1

    Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1
    
    PR-URL: #40658
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    8e52563 View commit details
    Browse the repository at this point in the history
  10. doc: update maintaining ICU guide

    Do not ask to separate the changes in deps/icu-small and in the
    LICENSE file.
    Do not ask to remove the whitespace changes. The way commits are
    landed now doesn't eliminate them anymore.
    
    PR-URL: #40658
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    9271f23 View commit details
    Browse the repository at this point in the history
  11. doc: fix corepack grammar for --force flag

    PR-URL: #40762
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    styfle authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    d3070d8 View commit details
    Browse the repository at this point in the history
  12. http: change totalSocketCount only on socket creation/close

    PR-URL: #40572
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    jodevsa authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    80ce97f View commit details
    Browse the repository at this point in the history
  13. src: add and fix some preprocessor comments

    PR-URL: #40701
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    tniessen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    924d29e View commit details
    Browse the repository at this point in the history
  14. src: add x509.fingerprint512 to crypto module

    PR-URL: #39809
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    3nprob authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    0de2850 View commit details
    Browse the repository at this point in the history
  15. doc: fix linter-enforced formatting in crypto.md

    The markdown-linter (lint-md) is failing because of a missing newline
    caused by 79d6815.
    
    PR-URL: #40780
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    VoltrexKeyva authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    5ceb06c View commit details
    Browse the repository at this point in the history
  16. test: fix flaky test-policy-integrity

    Split the test into seven tests so that it doesn't time out.
    
    Fixes: #40694
    Fixes: #38088
    
    PR-URL: #40763
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    3d89623 View commit details
    Browse the repository at this point in the history
  17. deps: upgrade npm to 8.1.3

    PR-URL: #40726
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    npm-robot authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    9711ccf View commit details
    Browse the repository at this point in the history
  18. crypto: fix build without scrypt

    * add missing semicolon to fix:
      In file included from ../src/node_crypto.h:47,
                       from ../src/node.cc:46:
      ../src/crypto/crypto_scrypt.h:80:2:
      error: expected ';' after struct definition
         80 | }
            |  ^
            |  ;
    
      and fix typo in the comment
    
    Signed-off-by: Martin Jansa <martin.jansa@lge.com>
    
    PR-URL: #40613
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    shr-project authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    7f5931d View commit details
    Browse the repository at this point in the history
  19. doc: fix transform stream example

    There was a missing callback in the Transform#flush example
    implementation.
    
    PR-URL: #40777
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    evanlucas authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    8166b07 View commit details
    Browse the repository at this point in the history
  20. http: add missing initialization

    Add missing initialization reported by coverity scan.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40555
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    bddb4c6 View commit details
    Browse the repository at this point in the history
  21. fs: nullish coalescing to respect zero positional reads

    When the file read position is moved passing zero is
    not respected and `null` is used instead. PR fixes the
    issues by using nullish coalescing which will return
    the rhs only when the lhs is `null` or `undefined`;
    respecting the zero.
    
    Fixes: #40715
    
    PR-URL: #40716
    Fixes: #40699
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    mihilmy authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    a5a1691 View commit details
    Browse the repository at this point in the history
  22. src: prevent extra copies of TimerWrap::TimerCb

    I noticed that we were taking `TimerCb` as a `const&` and then copying
    that into the member. This is completely fine when the constructor is
    called with an lvalue. However, when called with an rvalue, we can allow
    the `std::function` to be moved into the member instead of falling back
    to a copy, so I changed the constructors to take in universal
    references. Also, `std::function` constructors can take in multiple
    arguments, so I further modified the constructors to use variadic
    templates.
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40665
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    3be49d6 View commit details
    Browse the repository at this point in the history
  23. src,crypto: refactor crypto_tls.*

    By the design of `GetSSLError()`, the V8 API was unnecessarily being
    accessed in places where it eventually didn't get used. So this refactor
    inlines the function appropriately in places where it was being used.
    Also, this replaces uses of `AllocatedBuffers` with `BackingStore`s.
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40675
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    415b42f View commit details
    Browse the repository at this point in the history
  24. async_hooks: expose async_wrap providers

    docs: add asyncWrapProviders api doc
    
    tests(async_hooks): use internalBinding for comparisson
    
    fix(test-async-wrap): lint error
    
    docs: use REPLACEME for asyncWrapProviders
    
    update: use freeze and copy for asyncWrapProviders
    
    update(async_hooks): use primordials on asyncWrapProviders
    
    fix: use common to expect error
    
    docs(asyncWrapProviders): rephrase return type
    
    fix: lint md
    
    fix: lint md
    
    docs(async_hooks): typo
    
    Co-authored-by: Stephen Belanger <admin@stephenbelanger.com>
    
    update(asyncWrapProviders): add __proto__ as null
    
    Co-authored-by: Simone Busoli <simone.busoli@gmail.com>
    Co-authored-by: Michaël Zasso <targos@protonmail.com>
    
    test: adjust __proto__ assertion
    
    docs: add DEP0111 link
    
    PR-URL: #40760
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    RafaelGSS authored and targos committed Nov 21, 2021
    1 Configuration menu
    Copy the full SHA
    0691649 View commit details
    Browse the repository at this point in the history
  25. lib: fix typos in lib code comments

    PR-URL: #40792
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kuriyosh authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    10a842d View commit details
    Browse the repository at this point in the history
  26. tools: only validate first commit message of a PR

    PR-URL: #40740
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    727b34e View commit details
    Browse the repository at this point in the history
  27. src,crypto: remove AllocatedBuffers from crypto_spkac

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40752
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    RaisinTen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    82b4226 View commit details
    Browse the repository at this point in the history
  28. async_hooks: eliminate require side effects

    PR-URL: #40782
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Stephen Belanger authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    4a971f6 View commit details
    Browse the repository at this point in the history
  29. doc: claim ABI version for Electron 18

    PR-URL: #40768
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    VerteDinde authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    2ea08e9 View commit details
    Browse the repository at this point in the history
  30. stream: allow calling callback before promise

    Refs: #39535
    
    PR-URL: #40772
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    7c4f9a3 View commit details
    Browse the repository at this point in the history
  31. doc: tweak guidance for modules in core

    Generalize guidance so that it is not specific
    to modules.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40601
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    c91a9ab View commit details
    Browse the repository at this point in the history
  32. meta: edit GOVERNANCE.md for minor updates

    PR-URL: #40798
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    e451ec9 View commit details
    Browse the repository at this point in the history
  33. stream: fix non readable Duplex readableAborted

    PR-URL: #40801
    Fixes: #40800
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    7d127d2 View commit details
    Browse the repository at this point in the history
  34. crypto: throw errors in SignTraits::DeriveBits

    Fixes: #40794
    
    PR-URL: #40796
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    2979c58 View commit details
    Browse the repository at this point in the history
  35. test: add tests for invalid UTF-8

    Verify that `Blob.prototype.text()`, `streamConsumers.text()` and
    `TextDecoder.prototype.decode()` work as expected with invalid UTF-8.
    
    PR-URL: #40351
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    git-srinivas authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    150c0f1 View commit details
    Browse the repository at this point in the history
  36. meta: update AUTHORS

    PR-URL: #40809
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    813cf74 View commit details
    Browse the repository at this point in the history
  37. deps: add -fno-strict-aliasing flag to libuv

    This commit turns on `-fno-strict-aliasing` in libuv.
    
    Fixes: #40368
    Refs: libuv/libuv#1230
    
    PR-URL: #40631
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danbev authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    fa37428 View commit details
    Browse the repository at this point in the history
  38. src,doc: add SyntaxError napi support

    Add `napi_create_syntax_error` and `napi_throw_syntax_error`.
    
    Fixes: nodejs/node-addon-api#1099
    
    PR-URL: #40736
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Idan Attias authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    88b57bc View commit details
    Browse the repository at this point in the history
  39. process: support hrtime in the snapshot

    Put the hrtime backing store in the process methods binding data
    so that it can be integrated into the snapshot builder. For
    now we simply discard the contents of the hrtime buffer during
    serialization and create new buffers upon deserialization because
    the contents are only useful in a synchronous call.
    
    This also moves the helper function for creating V8 FastAPI methods
    into `Environment::SetFastMethod()` for code reuse. The v8::CFunction
    need to be created before the Environment is created so that we
    have the CTypeInfo address available for external reference
    registration.
    
    PR-URL: #40649
    Refs: #35711
    Refs: #37476
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    3a4f387 View commit details
    Browse the repository at this point in the history
  40. crypto: trim input for NETSCAPE_SPKI_b64_decode

    PR-URL: #40757
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    codebytere authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    a8cc8b6 View commit details
    Browse the repository at this point in the history
  41. src: reset error struct if error code is napi_ok

    PR-URL: #40552
    Refs: nodejs/node-addon-api#1089
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    JckXia authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    c2259c9 View commit details
    Browse the repository at this point in the history
  42. test: deflake child-process-pipe-dataflow

    Fixes: #25988
    
    PR-URL: #40838
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    896073b View commit details
    Browse the repository at this point in the history
  43. doc: fix added: info for Readable.fromWeb()

    `stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.
    
    PR-URL: #40820
    Refs: #40818
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    lpinca authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    fe2cd09 View commit details
    Browse the repository at this point in the history
  44. stream: pipeline should drain empty readable

    This simplifies some cases where the last stream is a Duplex
    without any expected output.
    
    await pipeline(readable, duplex)
    
    PR-URL: #40654
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    16ee842 View commit details
    Browse the repository at this point in the history
  45. test: add AsyncLocalStorage tests using udp, tcp and tls sockets

    Fixes: #40693
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40741
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    RaisinTen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    43e8650 View commit details
    Browse the repository at this point in the history
  46. Revert "lib: use helper for readability"

    This reverts commit 937bbc5.
    
    PR-URL: #40741
    Fixes: #40693
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    RaisinTen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    b614b17 View commit details
    Browse the repository at this point in the history
  47. Revert "async_hooks: merge resource_symbol with owner_symbol"

    This reverts commit 7ca2f13.
    
    PR-URL: #40741
    Fixes: #40693
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    RaisinTen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    48157c4 View commit details
    Browse the repository at this point in the history
  48. meta: update name and email

    PR-URL: #40848
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    null8626 authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    dfc6fc9 View commit details
    Browse the repository at this point in the history
  49. doc: add pref to using draft PR versus WIP label

    - add to the contribution guide that we prefer that
      people use draft PRs instead of the WIP label.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40824
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    9c200e1 View commit details
    Browse the repository at this point in the history
  50. build: fix tools.yml errors

    PR-URL: #40870
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    e793331 View commit details
    Browse the repository at this point in the history
  51. doc: improve README.md lede section

    Use clear and concise language.
    
    PR-URL: #40837
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    Trott authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    dfdf68f View commit details
    Browse the repository at this point in the history
  52. doc: document optional params in napi_get_cb_info

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40821
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    4c47b01 View commit details
    Browse the repository at this point in the history
  53. deps: update to uvwasi 0.0.12

    Notable changes:
    
    - Several overflows have been fixed.
    - The libuv dependency has been updated to v1.42.0.
    
    PR-URL: #40847
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    b46184d View commit details
    Browse the repository at this point in the history
  54. tools: update @babel/eslint-parser to 7.16.3

    PR-URL: #40889
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    de4d018 View commit details
    Browse the repository at this point in the history
  55. doc: define "types", "deno" community conditions

    PR-URL: #40708
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    guybedford authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    694012b View commit details
    Browse the repository at this point in the history
  56. test: use descriptive name for destination file

    `http2-url-tests.js` is misleading. Use the same name of the source file
    instead.
    
    PR-URL: #40842
    Fixes: #40277
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    lpinca authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    c485460 View commit details
    Browse the repository at this point in the history
  57. test: deflake http2-pipe-named-pipe

    Wait for all data to be read before sending the response and closing
    the client.
    
    Fixes: #40277
    
    PR-URL: #40842
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    lpinca authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    b190b0e View commit details
    Browse the repository at this point in the history
  58. test: fix argument order in assertion

    The first argument is the actual value, the second argument is the
    expected value.
    
    PR-URL: #40842
    Fixes: #40277
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    lpinca authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    522a30f View commit details
    Browse the repository at this point in the history
  59. deps: V8: cherry-pick 7ae0b77628f6

    Original commit message:
    
        [interpreter] Stop jump-table optimizing switch stms when spread overflows
    
        Bug: v8:12389
        Change-Id: I53c728ab0c8ba38c7dd96c7e1089f771ba44b9f0
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289227
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Commit-Queue: Leszek Swirski <leszeks@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#77995}
    
    Refs: v8/v8@7ae0b77
    
    PR-URL: #40882
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rayw000 authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    a612ecb View commit details
    Browse the repository at this point in the history
  60. deps: V8: cherry-pick cced52a97ee9

    Original commit message:
    
        [date] Skip leading zeros when parsing date string
    
        1. Skip leading zeros when parsing date string
        2. Add necessary unittests
    
        Bug: v8:12256
        Change-Id: Ibc1f320382a2e33175f7f57542c8fe48afd05fa8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3223239
        Reviewed-by: Shu-yu Guo <syg@chromium.org>
        Reviewed-by: Igor Sheludko <ishell@chromium.org>
        Commit-Queue: Shu-yu Guo <syg@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#77592}
    
    Refs: v8/v8@cced52a
    
    PR-URL: #40656
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rayw000 authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    6506a42 View commit details
    Browse the repository at this point in the history
  61. deps: update V8 to 9.6.180.14

    PR-URL: #40488
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    371ee64 View commit details
    Browse the repository at this point in the history
  62. build: reset embedder string to "-node.0"

    PR-URL: #40488
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    69de8c8 View commit details
    Browse the repository at this point in the history
  63. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: #32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    1ff83c4 View commit details
    Browse the repository at this point in the history
  64. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: #32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    29a6e15 View commit details
    Browse the repository at this point in the history
  65. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: #32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    d6e5dd5 View commit details
    Browse the repository at this point in the history
  66. deps: make v8.h compatible with VS2015

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693
    
    PR-URL: #32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joaocgreis authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    eab5ef5 View commit details
    Browse the repository at this point in the history
  67. deps: fix V8 build issue with inline methods

    PR-URL: #35415
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    
    deps: patch for v8 on windows
    
    PR-URL: #40010
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    
    deps: patch v8 for vs2019 in std17
    
    PR-URL: #40060
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    
    deps: workaround debug link error on Windows
    
    PR-URL: #38807
    Refs: #38788
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    gengjiawen authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    82a8736 View commit details
    Browse the repository at this point in the history
  68. deps: silence irrelevant V8 warning

    PR-URL: #37587
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    9ecf4be View commit details
    Browse the repository at this point in the history
  69. deps: silence irrelevant V8 warning

    PR-URL: #38990
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    dfb97fb View commit details
    Browse the repository at this point in the history
  70. deps: disable trap handler for Windows cross-compiler

    `handler-outside-simulator.cc` uses inline assembly, which is not
    supported by MSVC.
    
    PR-URL: #40488
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    37c9828 View commit details
    Browse the repository at this point in the history
  71. deps: V8: patch jinja2 for Python 3.10 compat

    PR-URL: #40296
    Fixes: #40294
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    94acaae View commit details
    Browse the repository at this point in the history
  72. deps: V8: cherry-pick 2a0bc36dec12

    Original commit message:
    
        [parser] Fix the MSVC build
    
        MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString
        method despite it being unused. This CL adds an (unreachable)
        definition for it.
    
        Bug: v8:12266
        Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Commit-Queue: Jakob Gruber <jgruber@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#77313}
    
    Refs: v8/v8@2a0bc36
    
    PR-URL: #40178
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    e60053d View commit details
    Browse the repository at this point in the history
  73. deps: V8: cherry-pick 7ae0b77628f6

    Original commit message:
    
        [interpreter] Stop jump-table optimizing switch stms when spread overflows
    
        Bug: v8:12389
        Change-Id: I53c728ab0c8ba38c7dd96c7e1089f771ba44b9f0
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289227
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Commit-Queue: Leszek Swirski <leszeks@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#77995}
    
    Refs: v8/v8@7ae0b77
    
    PR-URL: #40882
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rayw000 authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    d6ae50f View commit details
    Browse the repository at this point in the history
  74. deps: V8: cherry-pick cced52a97ee9

    Original commit message:
    
        [date] Skip leading zeros when parsing date string
    
        1. Skip leading zeros when parsing date string
        2. Add necessary unittests
    
        Bug: v8:12256
        Change-Id: Ibc1f320382a2e33175f7f57542c8fe48afd05fa8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3223239
        Reviewed-by: Shu-yu Guo <syg@chromium.org>
        Reviewed-by: Igor Sheludko <ishell@chromium.org>
        Commit-Queue: Shu-yu Guo <syg@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#77592}
    
    Refs: v8/v8@cced52a
    
    PR-URL: #40656
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rayw000 authored and targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    d461603 View commit details
    Browse the repository at this point in the history
  75. tools: update V8 gypfiles for 9.6

    PR-URL: #40488
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    e3f8988 View commit details
    Browse the repository at this point in the history
  76. tools: disable trap handler for Windows cross-compiler

    `handler-outside-simulator.cc` uses inline assembly, which is not
    supported by MSVC.
    
    PR-URL: #40488
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    d97ad30 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. tools: add find-inactive-tsc

    Automate the implementation of rules in the TSC Charter around automatic
    removal of members who do not participate in TSC votes and attend fewer
    than 25% of the meetings in a 3-month period.
    
    PR-URL: #40884
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    878ba91 View commit details
    Browse the repository at this point in the history
  2. test: deflake fs-promises-watch

    Change the contents of the file every 100 milliseconds until the watcher
    notices the change. This is already done in the callback based version
    of the test (`test-fs-watch.js`).
    
    Fixes: #37637
    
    PR-URL: #40863
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    lpinca authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    009ab4d View commit details
    Browse the repository at this point in the history
  3. test: deflake cluster-concurrent-disconnect

    Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
    allowed/expected code.
    
    Fixes: #38405
    
    PR-URL: #40877
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    lpinca authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4288c6a View commit details
    Browse the repository at this point in the history
  4. build: fix make invocation in tools.yml

    Be in the correct directory for `make lint-md-rollup`.
    
    PR-URL: #40890
    Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    1482c44 View commit details
    Browse the repository at this point in the history
  5. deps: upgrade npm to 8.1.4

    PR-URL: #40865
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    npm-robot authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    90f35fc View commit details
    Browse the repository at this point in the history
  6. stream: fix finished regression when working with legacy Stream

    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    
    PR-URL: #40858
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    mcollina authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    534409d View commit details
    Browse the repository at this point in the history
  7. stream: pipeline with end option

    Currently pipeline cannot fully replace pipe due
    to the missing end option. This PR adds the end
    option to the promisified pipeline method.
    
    PR-URL: #40886
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    650c9bd View commit details
    Browse the repository at this point in the history
  8. tools: update ESLint to 8.3.0

    PR-URL: #40917
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    lpinca authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    e674f61 View commit details
    Browse the repository at this point in the history
  9. tools: update lint-md dependencies

    Patch updates for remark-parse, remark-stringify, and unified.
    
    Patch updates to rollup plugins and minor update to rollup.
    
    PR-URL: #40894
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3d593aa View commit details
    Browse the repository at this point in the history
  10. doc: clarify more optional parameters in node-api

    Refs: nodejs/abi-stable-node#252
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40888
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    cf495a6 View commit details
    Browse the repository at this point in the history
  11. build: fix branch name for lint-md-dependencies update

    Refs: https://github.com/nodejs/node/runs/4288412090?check_suite_focus=true
    
    PR-URL: #40924
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    05d652a View commit details
    Browse the repository at this point in the history
  12. test: improve test coverage of readline/promises

    PR-URL: #40876
    Refs: https://coverage.nodejs.org/coverage-0c2011c6c5d311a9/lib/readline/promises.js.html#L33
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kuriyosh authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    ae12a60 View commit details
    Browse the repository at this point in the history
  13. tools: update lint-md-dependencies to rollup@2.60.1

    PR-URL: #40929
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    nodejs-github-bot authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    22265e3 View commit details
    Browse the repository at this point in the history
  14. meta: update AUTHORS

    PR-URL: #40900
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    9c897b6 View commit details
    Browse the repository at this point in the history
  15. test: mark test-fs-watch-non-recursive flaky on Windows

    Refs: #40728
    
    PR-URL: #40916
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    lpinca authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    62171eb View commit details
    Browse the repository at this point in the history
  16. lib: add reason to AbortSignal

    A new reason property was recently added to the AbortSignal spec.
    
    ```js
    const ac = new AbortController();
    ac.abort(new Error('boom!'));
    console.loc(ac.signal.reason);  // Error('boom!');
    ```
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #40807
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    jasnell authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    675c210 View commit details
    Browse the repository at this point in the history
  17. doc: fix spelling of 'WebAssembly'

    PR-URL: #40785
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    GeoffreyBooth authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b92416f View commit details
    Browse the repository at this point in the history
  18. module: import assertions improvements

    PR-URL: #40785
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    GeoffreyBooth authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3c8aa21 View commit details
    Browse the repository at this point in the history
  19. tools: ping TSC members identified as inactive

    When detecting TSC members as inactive, @-mention them in the pull
    request that moves them to emeritus. This notifies them in case the pull
    request is in error.
    
    PR-URL: #40915
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    0201f3f View commit details
    Browse the repository at this point in the history
  20. repl: fix and extend require/import tab complete

    PR-URL: #40216
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Mesteery authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    1555dbd View commit details
    Browse the repository at this point in the history
  21. src,crypto: use ByteSource::ToBuffer() in crypto_dh

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40903
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    RaisinTen authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    acbd822 View commit details
    Browse the repository at this point in the history
  22. build: remove extraneous quotation marks from commit body

    Refs: #40915 (comment)
    
    PR-URL: #40963
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    65b33ba View commit details
    Browse the repository at this point in the history
  23. stream: fix the ReadableStreamBYOBReader error message

    PR-URL: #40846
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    jasnell authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    dc99ae3 View commit details
    Browse the repository at this point in the history
  24. doc: remove experimental abortcontroller flag

    PR-URL: #38968
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    iam-frankqiu authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    6e9b665 View commit details
    Browse the repository at this point in the history
  25. tools: fix commit-lint GH Actions CI

    PR-URL: #40845
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    6ebbd0d View commit details
    Browse the repository at this point in the history
  26. doc: update BUILDING.md section on running tests

    Refs: #40920
    
    PR-URL: #40933
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    130777a View commit details
    Browse the repository at this point in the history
  27. tools: update gyp-next to v0.10.1

    PR-URL: #40934
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    747247b View commit details
    Browse the repository at this point in the history
  28. meta: add feature request label for issue template

    PR-URL: #40970
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Mesteery authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3ec78d1 View commit details
    Browse the repository at this point in the history
  29. stream: deprecate thenable support

    Deprecate support for returning thenables in stream
    implementation methods. This is causing more confusion
    and issues than it's worth, and never was documented.
    
    Refs: #39535
    
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    
    PR-URL: #40860
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    fa9b5c3 View commit details
    Browse the repository at this point in the history
  30. doc: improve grammar in API description

    PR-URL: #40959
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8966ab3 View commit details
    Browse the repository at this point in the history
  31. doc: add information on suppressing initial break in debugger

    Closes: #40857
    
    PR-URL: #40960
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3bfc9f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. stream: drain Transform with 0 highWaterMark

    Fixes: #40935
    
    PR-URL: #40947
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    ronag authored and targos committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    86d1c0b View commit details
    Browse the repository at this point in the history
  2. stream: stricter isReadableNodeStream

    Fixes: #40938
    
    PR-URL: #40941
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and targos committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    70bd90e View commit details
    Browse the repository at this point in the history
  3. 2021-11-30, Version 17.2.0 (Current)

    Notable changes:
    
    async_hooks:
      * (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760
    deps:
      * (SEMVER-MINOR) update V8 to 9.6.180.14 (Michaël Zasso) #40488
    lib:
      * (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807
    src:
      * (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809
    stream:
      * deprecate thenable support (Antoine du Hamel) #40860
      * fix finished regression when working with legacy Stream (Matteo Collina) #40858
    
    PR-URL: #40983
    targos committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    1aaa4eb View commit details
    Browse the repository at this point in the history