Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.9.0 proposal #42613

Merged
merged 96 commits into from
Apr 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
9344a06
tools: fix skip PR if CI is still running
meixg Mar 21, 2022
10d638a
doc: update property name
Trott Mar 21, 2022
e763e57
doc: unify import order in CCM example
tniessen Mar 21, 2022
878148c
src: refactor IsSupportedAuthenticatedMode
tniessen Mar 21, 2022
5589a44
doc,test: clarify ChaCha20-Poly1305 usage
tniessen Mar 21, 2022
f9f3b6e
node-api: format Node-API related code
vmoroz Mar 18, 2022
abbb236
doc: standardize typography for _semantic versioning_
Trott Mar 21, 2022
bb71433
async_hooks: remove destroyed symbol on Promises
Flarna Mar 21, 2022
00f693b
doc: make header smaller and dropdown click-driven when JS is on
ShogunPanda Mar 22, 2022
c6a558c
src: suppress false coverity warning
mhdawson Mar 10, 2022
3a1b0e5
tools: bump cpplint to 1.6.0
Trott Mar 21, 2022
13dd8e7
tools: refloat 7 Node.js patches to cpplint.py
Trott Oct 9, 2020
d302d2f
bootstrap: use SnapshotData to pass snapshot data around
joyeecheung Mar 15, 2022
48bd9fa
doc: add `trace_gc` to diagnostic tooling support document
tony-go Mar 23, 2022
5869275
doc: fix typo in async_context.md
AnupamaCodippily Mar 23, 2022
30dc6dd
deps: update undici to 4.16.0
nodejs-github-bot Mar 23, 2022
ce4b823
doc: add link to section
Trott Mar 24, 2022
fb146f9
doc: change comma-splice to two sentences
Trott Mar 26, 2022
ce9d840
src: properly report exceptions from AddressToJS()
RaisinTen Mar 26, 2022
334cc19
doc: expand history for conditional exports changes in v12
gpoole Mar 26, 2022
7124f91
crypto: make authTagLength optional for CC20P1305
tniessen Mar 27, 2022
41c2a32
meta: update AUTHORS
nodejs-github-bot Mar 27, 2022
3c3684d
doc: clarify napi_finalize behavior
mildsunrise Mar 27, 2022
464e57f
tools: update lint-md-dependencies to vfile-reporter@7.0.4
nodejs-github-bot Mar 27, 2022
b74de21
lib: update JSDoc for linting
Trott Mar 27, 2022
c6bfb22
tools: update eslint to 8.12.0
nodejs-github-bot Mar 27, 2022
7cf9feb
doc: remove comma splice in events.md
Trott Mar 27, 2022
19c933c
test,fs: add fs.rm() tests for .git directories
RaisinTen Mar 28, 2022
c6808f0
build: bump actions/checkout
UltiRequiem Mar 25, 2022
d335add
doc: fix question promise API example
meixg Mar 28, 2022
28665a9
doc: update security release onboarding
joesepi Mar 28, 2022
52d1c8d
test: add trace-gc flag test
tony-go Mar 28, 2022
2f68209
test: fix typos in test/parallel
daeyeon Mar 28, 2022
902776e
esm: emit experimental warnings in common place
JakobJingleheimer Mar 28, 2022
b71a810
net,dns: trace tcp connection and dns by perf_hooks
theanarkh Mar 29, 2022
6c13988
doc: suggest checkHost in checkServerIdentity docs
tniessen Mar 29, 2022
2e6a66d
src: address 3 useless call coverity warnings
mhdawson Mar 21, 2022
bff9cae
tools: update GHA actions version
aduh95 Mar 30, 2022
9a54acb
child_process: add env contents types in JSDoc
Trott Mar 30, 2022
b9ab986
doc: add `stability` class to legacy status description
danielroe Mar 30, 2022
1454c02
doc: fix comment text in async_hooks example
Trott Mar 30, 2022
a348f8a
src,crypto: remove uses of AllocatedBuffer from crypto_dh.cc
RaisinTen Mar 27, 2022
0c54f36
src: remove unnecessary static qualifier in crypto_dh.cc
RaisinTen Mar 27, 2022
970483f
src,crypto: handle empty maybe correctly in crypto_dh.cc
RaisinTen Mar 27, 2022
e3683cb
bootstrap: refresh options in pre-execution
joyeecheung Jun 11, 2021
f9fb7f6
build: add --node-snapshot-main configure option
joyeecheung Mar 24, 2022
1775586
bootstrap: make I/O streams work with user-land snapshot
joyeecheung Mar 25, 2022
b89f038
bootstrap: run inspector and event loop in snapshot builder
joyeecheung Mar 24, 2022
b48a6cb
bootstrap: reset process._exit and process.exitCode in pre-execution
joyeecheung Mar 26, 2022
a9f2636
tools: fixed bug causing JSON format to be broken
mawaregetsuka Mar 31, 2022
ffc6776
doc: add suggestion for OpenSSL only sec releases
mhdawson Mar 24, 2022
f2355e4
doc: fix internal link in collaborator-guide.md
daeyeon Apr 1, 2022
b819af6
doc: guide towards x509.fingerprint256
tniessen Apr 1, 2022
53584fa
doc: remove extraneous comma
Trott Apr 1, 2022
fd45df3
doc: document breaking change in `http.IncomingMessage` `'close'` event
ShogunPanda Apr 1, 2022
a1fe0d2
src: fix typo in InspectorIoDelegate constructor
cola119 Apr 1, 2022
d935fef
doc: consolidate CI sections
Trott Apr 1, 2022
8c9b5e9
test: fix typo in common/wpt.js
eltociear Apr 2, 2022
f0fc274
doc: add @meixg to collaborators
meixg Apr 2, 2022
541a132
crypto: fix webcrypto derive key lengths
panva Apr 2, 2022
9449242
doc: add introduction sentence for CJS
aduh95 Apr 2, 2022
f45d553
buffer: fix `atob` input validation
aduh95 Apr 2, 2022
797994e
test: add test for exception handlings in debugger
cola119 Apr 2, 2022
9055457
test: improve `FileHandle.prototype.write` coverage
aduh95 Apr 2, 2022
f41a478
test: pass data into napi_create_external
joyeecheung Apr 2, 2022
3bac969
lib: improve the coverage of the validator
mawaregetsuka Apr 2, 2022
8b08bff
doc: remove util.promisify() content in readline.md
Trott Apr 3, 2022
8333fa0
doc: update DEP0102 text
Trott Apr 1, 2022
dcf0abf
doc: simplify recommendation in webcrypto.md
Trott Apr 1, 2022
c036800
doc: clarify recommendations in stream.md
Trott Apr 1, 2022
2565090
meta: update AUTHORS
nodejs-github-bot Apr 3, 2022
1c61418
doc: simplify recommendations in process.md
Trott Apr 1, 2022
4cbb1ea
test: remove hack for `atob` and `btoa` WPT tests
aduh95 Apr 3, 2022
fb25ba4
test: improve lib/internal/readline/promises.js coverage
fossamagna Apr 3, 2022
9b4bd7d
crypto: cleanup webcrypto jwk code
panva Apr 3, 2022
71ab0de
doc: aes webcrypto unwrap is not a node-specific extensions
panva Apr 3, 2022
a2f0738
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
panva Apr 3, 2022
e798e26
src: add proper mutexes for accessing FIPS state
addaleax Apr 3, 2022
c83ea22
doc: change "OCSP Request" to "OCSP request"
tniessen Apr 3, 2022
ecb5be8
build: set stale action back to running nightly
mhdawson Apr 3, 2022
93ffc55
meta: move one or more collaborators to emeritus
nodejs-github-bot Apr 3, 2022
0bd9d9e
os: avoid unnecessary usage of var
VoltrexKeyva Apr 3, 2022
3306fee
lib: source maps filter null prefix
fabiancook Apr 3, 2022
71f4a39
doc: fix documentation of `FileHandle.prototype.appendFile`
aduh95 Apr 3, 2022
beffed1
doc: remove faulty justification for 128-bit AES
tniessen Apr 3, 2022
d9a1d78
build: consolidate JS and md linting GitHub Actions
Trott Apr 3, 2022
a9dc3a9
lib: prepare files for no-var lint rule
Trott Apr 2, 2022
d64c4fb
tools: enable no-var ESLint rule for lib
Trott Apr 2, 2022
eb3dfc0
buffer: improve Blob constructor error message when passing a string
meixg Apr 4, 2022
7766bf9
meta: update .mailmap and AUTHORS
Trott Apr 4, 2022
1f7d2e8
build: windows/arm64 native compilation support
niyas-sait Apr 5, 2022
261672b
doc: remove obsolete stream API selection text
Trott Apr 5, 2022
fb6a5ba
build: remove precompiled header and debug information for host builds
niyas-sait Apr 5, 2022
6e56924
doc: simplify Http2Stream encoding text
Trott Apr 6, 2022
8009cb0
fs: fix write methods param validation and docs
LiviaMedeiros Apr 4, 2022
70dcef5
2022-04-07, Version 17.9.0 (Current)
juanarbol Apr 6, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ tools/icu
tools/lint-md/lint-md.mjs
benchmark/tmp
doc/**/*.js
!doc/api_assets/*.js
!.eslintrc.js
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ module.exports = {
'no-useless-concat': 'error',
'no-useless-constructor': 'error',
'no-useless-return': 'error',
'no-var': 'error',
'no-void': 'error',
'no-whitespace-before-property': 'error',
'object-curly-newline': 'error',
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/authors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: '0' # This is required to actually get all the authors
persist-credentials: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ jobs:
if: needs.get-prs-for-ci.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -55,25 +55,25 @@ jobs:
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: tarballs
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
with:
name: tarballs
path: tarballs
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ jobs:
fail-fast: false
runs-on: ${{ matrix.windows }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/close-stale-feature-requests.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
name: Close stale feature requests
on:
workflow_dispatch:
inputs:
daysBeforeStale:
description: Idle number of days before marking feature requests stale
required: true
default: 906
type: number
schedule:
# Run every day at 1:00 AM UTC.
- cron: 0 1 * * *

# yamllint disable rule:empty-lines
env:
Expand Down Expand Up @@ -39,7 +36,7 @@ jobs:
- uses: actions/stale@v4
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: ${{ github.event.inputs.daysBeforeStale }}
days-before-stale: 180
days-before-close: 30
stale-issue-label: stale
close-issue-message: ${{ env.CLOSE_MESSAGE }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ jobs:
run: |
echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
persist-credentials: false
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit message
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
if: needs.get_mergeable_prs.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
# Needs the whole git history for ncu to work
# See https://github.com/nodejs/node-core-utils/pull/486
Expand All @@ -55,7 +55,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install node-core-utils
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ jobs:
# not working on gcc-8 and gcc-9 see https://github.com/nodejs/node/issues/38570
container: gcc:11
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,18 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Build
run: NODE=$(command -v node) make doc-only
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
with:
name: docs
path: out/doc
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
persist-credentials: false

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ jobs:

steps:
- name: Checkout the repo
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0
persist-credentials: false

- name: Clone nodejs/TSC repository
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0
path: .tmp
persist-credentials: false
repository: nodejs/TSC

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- run: ./tools/license-builder.sh # Run the license builder tool
Expand Down
48 changes: 17 additions & 31 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand All @@ -38,65 +38,51 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Lint C/C++ files
run: make lint-cpp
lint-md:
lint-js-and-md:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Lint JavaScript files
run: NODE=$(command -v node) make lint-js
- name: Get release version numbers
if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
id: get-released-versions
run: ./tools/lint-md/list-released-versions-from-changelogs.mjs
- name: Lint docs
- name: Lint markdown files
run: |
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"
NODE=$(command -v node) make lint-md
env:
NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }}

lint-js:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v2
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Lint JavaScript files
run: NODE=$(command -v node) make lint-js
lint-py:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -109,11 +95,11 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Use Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -127,7 +113,7 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- run: shellcheck -V
Expand All @@ -137,7 +123,7 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- uses: mszostok/codeowners-validator@v0.6.0
Expand All @@ -147,7 +133,7 @@ jobs:
if: ${{ github.event.pull_request }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 2
persist-credentials: false
Expand Down
Loading