Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.9.0 proposal #42613

Merged
merged 96 commits into from
Apr 7, 2022
Merged

v17.9.0 proposal #42613

merged 96 commits into from
Apr 7, 2022

Commits on Apr 6, 2022

  1. tools: fix skip PR if CI is still running

    resolve: #40330
    
    PR-URL: #42377
    Fixes: #40330
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    meixg authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9344a06 View commit details
    Browse the repository at this point in the history
  2. doc: update property name

    Property name `min` was updated in 23637e9
    to `lowest` but an instance of `min` was missed.
    
    PR-URL: #42398
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    10d638a View commit details
    Browse the repository at this point in the history
  3. doc: unify import order in CCM example

    Refs: #39043
    
    PR-URL: #42394
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e763e57 View commit details
    Browse the repository at this point in the history
  4. src: refactor IsSupportedAuthenticatedMode

    Improve the function's structure and clarify the special handling of
    ChaCha20-Poly1305. Remove the IS_OCB_MODE macro.
    
    PR-URL: #42368
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    878148c View commit details
    Browse the repository at this point in the history
  5. doc,test: clarify ChaCha20-Poly1305 usage

    PR-URL: #42323
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5589a44 View commit details
    Browse the repository at this point in the history
  6. node-api: format Node-API related code

    PR-URL: #42396
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    vmoroz authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f9f3b6e View commit details
    Browse the repository at this point in the history
  7. doc: standardize typography for _semantic versioning_

    PR-URL: #42401
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    abbb236 View commit details
    Browse the repository at this point in the history
  8. async_hooks: remove destroyed symbol on Promises

    Promises are never destroyed manually therefore it's not needed to
    attach an object to track if destroy hook was called already.
    
    PR-URL: #42402
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Flarna authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    bb71433 View commit details
    Browse the repository at this point in the history
  9. doc: make header smaller and dropdown click-driven when JS is on

    PR-URL: #42165
    Fixes: #42286
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    ShogunPanda authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    00f693b View commit details
    Browse the repository at this point in the history
  10. src: suppress false coverity warning

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42284
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c6a558c View commit details
    Browse the repository at this point in the history
  11. tools: bump cpplint to 1.6.0

    PR-URL: #42416
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3a1b0e5 View commit details
    Browse the repository at this point in the history
  12. tools: refloat 7 Node.js patches to cpplint.py

    Cherry-pick 12c8b4d
    Original commit message:
        This commit is a suggestion for adding a rule for NULL usages in the
        code base. This will currently report a number of errors which could be
        ignored using // NOLINT (readability/null_usage)
    
        PR-URL: #17373
        Reviewed-By: Jon Moss <me@jonathanmoss.me>
        Reviewed-By: Anna Henningsen <anna@addaleax.net>
        Reviewed-By: Timothy Gu <timothygu99@gmail.com>
        Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
        Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
        Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
        Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    
    Refs: 12c8b4d
    
    Cherry-pick fc81e80
    Original commit message:
    
        Update cpplint.py to check for inline headers when the corresponding
        header is already included.
    
        PR-URL: #21521
        Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
        Reviewed-By: James M Snell <jasnell@gmail.com>
    
    Refs: fc81e80
    
    Cherry-pick cbc3dd9
    Original commit message:
    
        src, tools: add check for left leaning pointers
    
        This commit adds a rule to cpplint to check that pointers in the code
        base lean to the left and not right, and also fixes the violations
        reported.
    
        PR-URL: #21010
        Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
        Reviewed-By: Anna Henningsen <anna@addaleax.net>
        Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
        Reviewed-By: James M Snell <jasnell@gmail.com>
    
    Refs: cbc3dd9
    
    Cherry-pick 9029981
    Original commit message:
    
        tools: fix cpplint.py header rules
    
        THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.
    
        PR-URL: #26306
        Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    
    Refs: 9029981
    
    Cherry-pick 0a25ace
    Original commit message:
    
        tools: move cpplint configuration to .cpplint
    
        PR-URL: #27098
        Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
        Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    
    Refs: 0a25ace
    
    Cherry-pick afa9a72
    Original commit message:
    
        tools: refloat update link to google styleguide for cpplint
    
        This commit updates two old links to Google's C++ styleguide which
        currently result in a 404 when accessed.
    
        PR-URL: #30876
        Reviewed-By: Michaël Zasso <targos@protonmail.com>
        Reviewed-By: David Carlier <devnexen@gmail.com>
        Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
        Reviewed-By: Richard Lau <riclau@uk.ibm.com>
        Reviewed-By: Rich Trott <rtrott@gmail.com>
    
    Refs: afa9a72
    
    Cherry-pick e23bf8f
    Original commit message:
    
        tools,src: refloat forbid usage of v8::Persistent
    
        `v8::Persistent` comes with the surprising catch that it requires
        manual cleanup. `v8::Global` doesn’t, making it easier to use,
        and additionally provides move semantics. New code should always
        use `v8::Global`.
    
        PR-URL: #31018
        Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
        Reviewed-By: Richard Lau <riclau@uk.ibm.com>
        Reviewed-By: James M Snell <jasnell@gmail.com>
        Reviewed-By: David Carlier <devnexen@gmail.com>
        Reviewed-By: Rich Trott <rtrott@gmail.com>
        Reviewed-By: Gus Caplan <me@gus.host>
        Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
        Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
        Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    
    PR-URL: #35569
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    
    PR-URL: #35719
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    
    PR-URL: #35866
    
    PR-URL: #36213
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    
    PR-URL: #36235
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    
    PR-URL: #36324
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    
    PR-URL: #38851
    Reviewed-By: Khaidi Chu <i@2333.moe>
    
    PR-URL: #42416
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    13dd8e7 View commit details
    Browse the repository at this point in the history
  13. bootstrap: use SnapshotData to pass snapshot data around

    Instead of passing the snapshot blob, the per-isolate data
    indices and the EnvSerializeInfo separately, use the aggregate
    type Snapshot to carry these around, and refactor
    NodeMainInstance so that it owns the v8::Isolate::CreateParams
    when it owns its isolate. This also gets rid of the owns_isolate_
    and deserialize_mode_ booleans in NodeMainInstance since
    NodeMainInstance can compute these by just checking if it has
    pointers to the CreateParams or the SnapshotData.
    
    PR-URL: #42360
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d302d2f View commit details
    Browse the repository at this point in the history
  14. doc: add trace_gc to diagnostic tooling support document

    PR-URL: #42346
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    tony-go authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    48bd9fa View commit details
    Browse the repository at this point in the history
  15. doc: fix typo in async_context.md

    PR-URL: #42444
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Mestery <mestery@protonmail.com>
    AnupamaCodippily authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5869275 View commit details
    Browse the repository at this point in the history
  16. deps: update undici to 4.16.0

    PR-URL: #42414
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    30dc6dd View commit details
    Browse the repository at this point in the history
  17. doc: add link to section

    PR-URL: #42428
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ce4b823 View commit details
    Browse the repository at this point in the history
  18. doc: change comma-splice to two sentences

    PR-URL: #42455
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fb146f9 View commit details
    Browse the repository at this point in the history
  19. src: properly report exceptions from AddressToJS()

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42054
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RaisinTen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ce9d840 View commit details
    Browse the repository at this point in the history
  20. doc: expand history for conditional exports changes in v12

    Fixes: #36162
    
    PR-URL: #42339
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gpoole authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    334cc19 View commit details
    Browse the repository at this point in the history
  21. crypto: make authTagLength optional for CC20P1305

    PR-URL: #42427
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    7124f91 View commit details
    Browse the repository at this point in the history
  22. meta: update AUTHORS

    PR-URL: #42488
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nodejs-github-bot authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    41c2a32 View commit details
    Browse the repository at this point in the history
  23. doc: clarify napi_finalize behavior

    We currently defer finalizer callbacks until the loop is idle.
    Warn users that the weak reference returned by napi_wrap()
    isn't guaranteed to be valid just because the finalizer hasn't
    yet been called.
    
    PR-URL: #42461
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mildsunrise authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3c3684d View commit details
    Browse the repository at this point in the history
  24. tools: update lint-md-dependencies to vfile-reporter@7.0.4

    PR-URL: #42487
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nodejs-github-bot authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    464e57f View commit details
    Browse the repository at this point in the history
  25. lib: update JSDoc for linting

    Fix issue that will be flagged when we update ESLint and dependencies.
    
    PR-URL: #42489
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b74de21 View commit details
    Browse the repository at this point in the history
  26. tools: update eslint to 8.12.0

    PR-URL: #42489
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    nodejs-github-bot authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c6bfb22 View commit details
    Browse the repository at this point in the history
  27. doc: remove comma splice in events.md

    PR-URL: #42484
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    7cf9feb View commit details
    Browse the repository at this point in the history
  28. test,fs: add fs.rm() tests for .git directories

    Git for Windows creates read-only files inside the .git directory.
    fs.rm() was built in a way, to work around any EPERM error that can
    happen while deleting the .git directory by turning the directory
    into a writable one. This change adds a regression test for that.
    
    Refs: isaacs/rimraf#21
    Refs: #38810 (comment)
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42410
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    19c933c View commit details
    Browse the repository at this point in the history
  29. build: bump actions/checkout

    https://github.com/actions/checkout\#checkout-v3
    
    PR-URL: #42460
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    UltiRequiem authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c6808f0 View commit details
    Browse the repository at this point in the history
  30. doc: fix question promise API example

    PR-URL: #42465
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    meixg authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d335add View commit details
    Browse the repository at this point in the history
  31. doc: update security release onboarding

    This change is helpful when publishing release announcements.
    
    PR-URL: #42333
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joesepi authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    28665a9 View commit details
    Browse the repository at this point in the history
  32. test: add trace-gc flag test

    PR-URL: #42471
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    tony-go authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    52d1c8d View commit details
    Browse the repository at this point in the history
  33. test: fix typos in test/parallel

    This pr fixes typos in some parallel tests.
    
    PR-URL: #42502
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    daeyeon authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    2f68209 View commit details
    Browse the repository at this point in the history
  34. esm: emit experimental warnings in common place

    PR-URL: #42314
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    JakobJingleheimer authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    902776e View commit details
    Browse the repository at this point in the history
  35. net,dns: trace tcp connection and dns by perf_hooks

    use the perf_hooks to trace the time spent by net.connect, dns.lookup,
    dns.lookupService, dns.resolvexxx.
    
    PR-URL: #42390
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    theanarkh authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b71a810 View commit details
    Browse the repository at this point in the history
  36. doc: suggest checkHost in checkServerIdentity docs

    Refs: #42470
    
    PR-URL: #42495
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6c13988 View commit details
    Browse the repository at this point in the history
  37. src: address 3 useless call coverity warnings

    Fix the last 3 useless call reports from coverity
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42426
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    2e6a66d View commit details
    Browse the repository at this point in the history
  38. tools: update GHA actions version

    PR-URL: #42498
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    bff9cae View commit details
    Browse the repository at this point in the history
  39. child_process: add env contents types in JSDoc

    Use JSDoc to indicate that the `env` object keys and values must be
    strings.
    
    Refs: #42489 (comment)
    
    PR-URL: #42494
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9a54acb View commit details
    Browse the repository at this point in the history
  40. doc: add stability class to legacy status description

    PR-URL: #42525
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    danielroe authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b9ab986 View commit details
    Browse the repository at this point in the history
  41. doc: fix comment text in async_hooks example

    PR-URL: #42499
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1454c02 View commit details
    Browse the repository at this point in the history
  42. src,crypto: remove uses of AllocatedBuffer from crypto_dh.cc

    Refs: #39941
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42492
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a348f8a View commit details
    Browse the repository at this point in the history
  43. src: remove unnecessary static qualifier in crypto_dh.cc

    ZeroPadDiffieHellmanSecret() is in an anonymous namespace, so it has
    static linkage already.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42492
    Refs: #39941
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0c54f36 View commit details
    Browse the repository at this point in the history
  44. src,crypto: handle empty maybe correctly in crypto_dh.cc

    Buffer::Length() dereferences the passed Local, so calling it when the
    underlying pointer is a nullptr would lead to a crash. This fixes that
    by returning early instead.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42492
    Refs: #39941
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    970483f View commit details
    Browse the repository at this point in the history
  45. bootstrap: refresh options in pre-execution

    Refresh the options map during pre-execution to pave the way for
    user land snapshots which may need to access run-time options at
    snapshot-building time. The default embedded bootstrap snapshot
    is still prevented from accessing them at snapshot building time
    since it serves a wider audience and is ignorant of application
    states, while the user-land snapshots are meant to be
    application-specific and so it makes sense for them to access
    runtime states as long as the snapshotted-code
    works with re-initialized runtime states.
    
    PR-URL: #42466
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e3683cb View commit details
    Browse the repository at this point in the history
  46. build: add --node-snapshot-main configure option

    This adds a --build-snapshot runtime option which is currently only
    supported by the node_mksnapshot binary, and a --node-snapshot-main
    configure option that makes use it to run a custom script when
    building the embedded snapshot. The idea is to have this experimental
    feature in core as a configure-time feature for now, and investigate
    the renaming V8 bugs before we make it available to more users via
    making it a runtime option.
    
    PR-URL: #42466
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f9fb7f6 View commit details
    Browse the repository at this point in the history
  47. bootstrap: make I/O streams work with user-land snapshot

    Use the mksnapshot cleanup hooks to release the references
    to the native streams so that they can be destroyed right
    before the snapshot is taken, and move the initialization
    of the global console to pre-execution so that they can be
    re-initialized during snapshot dehydration. This makes
    it possible for user-land snapshots to use the I/O during
    snapshot building.
    
    PR-URL: #42466
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1775586 View commit details
    Browse the repository at this point in the history
  48. bootstrap: run inspector and event loop in snapshot builder

    This makes --inspect and stdin/out functional in the embedded snapshot,
    currently it's not guaranteed that these work perfectly, the
    plan is to investigate any out-of-sync states that might appear
    in user land snapshots with this while the it is a configure-time
    feature.
    
    PR-URL: #42466
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b89f038 View commit details
    Browse the repository at this point in the history
  49. bootstrap: reset process._exit and process.exitCode in pre-execution

    PR-URL: #42466
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b48a6cb View commit details
    Browse the repository at this point in the history
  50. tools: fixed bug causing JSON format to be broken

    PR-URL: #41565
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mawaregetsuka authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a9f2636 View commit details
    Browse the repository at this point in the history
  51. doc: add suggestion for OpenSSL only sec releases

    Fixes: nodejs/TSC#1187
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42456
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mhdawson authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ffc6776 View commit details
    Browse the repository at this point in the history
  52. doc: fix internal link in collaborator-guide.md

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    
    PR-URL: #42551
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    daeyeon authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f2355e4 View commit details
    Browse the repository at this point in the history
  53. doc: guide towards x509.fingerprint256

    Recommend using x509.fingerprint256 instead of x509.fingerprint and
    x509.fingerprint512 and suggest using it instead of x509.serialNumber
    in order to uniquely identify certificates.
    
    PR-URL: #42516
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b819af6 View commit details
    Browse the repository at this point in the history
  54. doc: remove extraneous comma

    PR-URL: #42548
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    53584fa View commit details
    Browse the repository at this point in the history
  55. doc: document breaking change in http.IncomingMessage 'close' event

    PR-URL: #42521
    Fixes: #38924
    Refs: #33035
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    ShogunPanda authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fd45df3 View commit details
    Browse the repository at this point in the history
  56. src: fix typo in InspectorIoDelegate constructor

    PR-URL: #42520
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    cola119 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a1fe0d2 View commit details
    Browse the repository at this point in the history
  57. doc: consolidate CI sections

    PR-URL: #42534
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d935fef View commit details
    Browse the repository at this point in the history
  58. test: fix typo in common/wpt.js

    thw -> the
    
    PR-URL: #42567
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    eltociear authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    8c9b5e9 View commit details
    Browse the repository at this point in the history
  59. doc: add @meixg to collaborators

    PR-URL: #42576
    Fixes: #42419
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    meixg authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f0fc274 View commit details
    Browse the repository at this point in the history
  60. crypto: fix webcrypto derive key lengths

    PR-URL: #42542
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    541a132 View commit details
    Browse the repository at this point in the history
  61. doc: add introduction sentence for CJS

    PR-URL: #42491
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    aduh95 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9449242 View commit details
    Browse the repository at this point in the history
  62. buffer: fix atob input validation

    Fixes: #42530
    
    PR-URL: #42539
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    aduh95 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f45d553 View commit details
    Browse the repository at this point in the history
  63. test: add test for exception handlings in debugger

    PR-URL: #42327
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    cola119 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    797994e View commit details
    Browse the repository at this point in the history
  64. test: improve FileHandle.prototype.write coverage

    Refs: #42518
    
    PR-URL: #42541
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    aduh95 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9055457 View commit details
    Browse the repository at this point in the history
  65. test: pass data into napi_create_external

    Since v8 10.1 v8::External::New DCHECKs that the data passed
    into it cannot be a nullptr because that's not serializable
    as external references. This updates the test to pass a
    dummy data pointer to the call - which does not matter for the
    test since we only care about whether the finalizer is
    called.
    
    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234
    
    PR-URL: #42532
    Refs: #42115
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    joyeecheung authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f41a478 View commit details
    Browse the repository at this point in the history
  66. lib: improve the coverage of the validator

    PR-URL: #42443
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mawaregetsuka authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3bac969 View commit details
    Browse the repository at this point in the history
  67. doc: remove util.promisify() content in readline.md

    PR-URL: #42552
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    8b08bff View commit details
    Browse the repository at this point in the history
  68. doc: update DEP0102 text

    PR-URL: #42553
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    8333fa0 View commit details
    Browse the repository at this point in the history
  69. doc: simplify recommendation in webcrypto.md

    PR-URL: #42554
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    dcf0abf View commit details
    Browse the repository at this point in the history
  70. doc: clarify recommendations in stream.md

    PR-URL: #42555
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c036800 View commit details
    Browse the repository at this point in the history
  71. meta: update AUTHORS

    PR-URL: #42585
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    2565090 View commit details
    Browse the repository at this point in the history
  72. doc: simplify recommendations in process.md

    Remove recommendation that has no explanation. Make the other
    recommendation less wordy.
    
    PR-URL: #42556
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1c61418 View commit details
    Browse the repository at this point in the history
  73. test: remove hack for atob and btoa WPT tests

    PR-URL: #42540
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Mestery <mestery@protonmail.com>
    aduh95 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    4cbb1ea View commit details
    Browse the repository at this point in the history
  74. test: improve lib/internal/readline/promises.js coverage

    PR-URL: #42420
    Refs: https://coverage.nodejs.org/coverage-419f02ba1f00cac3/lib/internal/readline/promises.js.html
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    fossamagna authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fb25ba4 View commit details
    Browse the repository at this point in the history
  75. crypto: cleanup webcrypto jwk code

    PR-URL: #42562
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    panva authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9b4bd7d View commit details
    Browse the repository at this point in the history
  76. doc: aes webcrypto unwrap is not a node-specific extensions

    PR-URL: #42561
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    panva authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    71ab0de View commit details
    Browse the repository at this point in the history
  77. crypto: do not add undefined hash in webcrypto normalizeAlgorithm

    PR-URL: #42559
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a2f0738 View commit details
    Browse the repository at this point in the history
  78. src: add proper mutexes for accessing FIPS state

    The FIPS state handling and OpenSSL initialization code makes
    accesses to global OpenSSL state without any protection against
    parallel modifications from multiple threads.
    
    This commit adds such protections.
    
    PR-URL: #42278
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    addaleax authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e798e26 View commit details
    Browse the repository at this point in the history
  79. doc: change "OCSP Request" to "OCSP request"

    PR-URL: #42582
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    c83ea22 View commit details
    Browse the repository at this point in the history
  80. build: set stale action back to running nightly

    I manually ran over  the last number of weeks so that
    we did not mark all of the stale isssues all at once.
    We are not caught up so we can go to running daily.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42549
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tierney Cyren <hello@bnb.im>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ecb5be8 View commit details
    Browse the repository at this point in the history
  81. meta: move one or more collaborators to emeritus

    PR-URL: #42500
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    93ffc55 View commit details
    Browse the repository at this point in the history
  82. os: avoid unnecessary usage of var

    The `var` keyword is known to be problematic and is not needed here,
    so better to use the `let` keyword for variable declarations.
    
    PR-URL: #42563
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    VoltrexKeyva authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0bd9d9e View commit details
    Browse the repository at this point in the history
  83. lib: source maps filter null prefix

    Fixes: #42417
    
    PR-URL: #42522
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    fabiancook authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3306fee View commit details
    Browse the repository at this point in the history
  84. doc: fix documentation of FileHandle.prototype.appendFile

    PR-URL: #42588
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    aduh95 authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    71f4a39 View commit details
    Browse the repository at this point in the history
  85. doc: remove faulty justification for 128-bit AES

    This sentence implies that AES-128 is preferred over AES-256 because
    of a related-key attack from 2009. However, that attack by Alex
    Biryukov, Orr Dunkelman, Nathan Keller, Dmitry Khovratovich, and Adi
    Shamir, while impressive, is only effective against variants of
    AES-256 with a reduced number of rounds and it requires related keys.
    This means that the attack is not effective against AES-256 as it is
    used within TLS.
    
    (AES-128 is still often preferred over AES-256 simply because it is
    believed to be sufficiently secure and because it is faster.)
    
    PR-URL: #42578
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    beffed1 View commit details
    Browse the repository at this point in the history
  86. build: consolidate JS and md linting GitHub Actions

    Linting markdown runs the JavaScript linting job, so consolidate them to
    conserve time and resources. Run JavaScript separately, but then run
    markdown linting so it can use the cached results of the JavaScript
    linting.
    
    PR-URL: #42572
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d9a1d78 View commit details
    Browse the repository at this point in the history
  87. lib: prepare files for no-var lint rule

    PR-URL: #42573
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a9dc3a9 View commit details
    Browse the repository at this point in the history
  88. tools: enable no-var ESLint rule for lib

    PR-URL: #42573
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d64c4fb View commit details
    Browse the repository at this point in the history
  89. buffer: improve Blob constructor error message when passing a string

    resolve: #38856
    
    PR-URL: #42338
    Fixes: #38856
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    meixg authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    eb3dfc0 View commit details
    Browse the repository at this point in the history
  90. meta: update .mailmap and AUTHORS

    Refs: #42599 (comment)
    
    PR-URL: #42602
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    7766bf9 View commit details
    Browse the repository at this point in the history
  91. build: windows/arm64 native compilation support

    Added support for detecting ARM64 host architecture for windows and
    avoid explicit cross-compilation flag for win/arm64 target as
    configure.py can auto-detect configuration from host and
    target architecture.
    
    Refs: nodejs/build#2540
    
    PR-URL: #42408
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    niyas-sait authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1f7d2e8 View commit details
    Browse the repository at this point in the history
  92. doc: remove obsolete stream API selection text

    PR-URL: #42586
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    261672b View commit details
    Browse the repository at this point in the history
  93. build: remove precompiled header and debug information for host builds

    PR-URL: #42538
    Refs: #42375
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    niyas-sait authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fb6a5ba View commit details
    Browse the repository at this point in the history
  94. doc: simplify Http2Stream encoding text

    PR-URL: #42597
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Trott authored and juanarbol committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6e56924 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. fs: fix write methods param validation and docs

    The FS docs wrongfully indicated support for passing object with an own
    `toString` function property to `FileHandle.prototype.appendFile`,
    `FileHandle.prototype.writeFile`, `FileHandle.prototype.write`,
    `fsPromises.writeFile`, and `fs.writeSync`. This commit fixes that, and
    adds some test to ensure the actual behavior is aligned with the docs.
    It also fixes a bug that makes the process crash if a non-buffer object
    was passed to `FileHandle.prototype.write`.
    
    Refs: #34993
    PR-URL: #41677
    Backport-PR-URL: #42631
    Refs: #41666
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    LiviaMedeiros authored and juanarbol committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    8009cb0 View commit details
    Browse the repository at this point in the history
  2. 2022-04-07, Version 17.9.0 (Current)

    Notable Changes:
    
    * (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) #42427
    * deps: update undici to 4.16.0 (Node.js GitHub Bot) #42414
    * doc: add @meixg to collaborators (Xuguang Mei) #42576
    
    PR-URL: #42613
    juanarbol committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    70dcef5 View commit details
    Browse the repository at this point in the history