Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix incorrect DNS cancel tests #44432

Merged
merged 1 commit into from
May 11, 2024
Merged

test: fix incorrect DNS cancel tests #44432

merged 1 commit into from
May 11, 2024

Conversation

szmarczak
Copy link
Member

@szmarczak szmarczak commented Aug 29, 2022 •
edited
Loading

Fixes #44428

Followup to #44022

Not sure what was I thinking at that moment, but calling resolve4 11 times sends out 11 datagrams as expected, so mustNotCall was actually wrong.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 29, 2022
@szmarczak szmarczak mentioned this pull request Aug 29, 2022
Merged
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46389/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46411/

@nodejs nodejs deleted a comment from nodejs-github-bot Sep 4, 2022
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47542/

This was referenced Oct 29, 2022
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49055/

This was referenced Jan 21, 2023
Open
Open
Open
Open
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59095/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59100/

@aduh95 aduh95 merged commit 8c0ec0f into nodejs:main May 11, 2024
53 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

Landed in 8c0ec0f

targos pushed a commit that referenced this pull request May 12, 2024
@szmarczak @targos
test: fix DNS cancel tests
f47e8fc 
PR-URL: #44432
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@szmarczak @marco-ippolito
test: fix DNS cancel tests
208c5e4 
PR-URL: #44432
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@szmarczak @marco-ippolito
test: fix DNS cancel tests
2013aca 
PR-URL: #44432
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@szmarczak @marco-ippolito
test: fix DNS cancel tests
0638274 
PR-URL: #44432
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@szmarczak @eliphazbouye
test: fix DNS cancel tests
186ca8f 
PR-URL: nodejs#44432
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@szmarczak @bmeck
test: fix DNS cancel tests
2e00e3b 
PR-URL: nodejs#44432
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS channel cancel tests do not work as intended
6 participants
@szmarczak @nodejs-github-bot @aduh95 @lpinca @joyeecheung @theanarkh