-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: dns.lookupService has wrong header level #552
Conversation
thanks @wizicer, would you mind having a look at CONTRIBUTING.md to see the expected commit message style? you should prefix the message with a "doc:" in this case. |
sorry for the inconvenience, I read the document again, and took a look at the closed PR, then submit again. Let me know if still something is missing. |
@wizicer Sorry to trouble you again but can you sign the commit with your real name? Thanks! |
@bnoordhuis I change the auther name of the commit, please review again. BTW, I'm curious about how you know I'm not using the right name the commit, I just knew we can get it from git client, but I can't find this type of information in github. |
PR-URL: #552 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@wizicer Thanks, landed in df0d790.
One of GH's many small tricks: when you add .patch to the PR URL, you get the raw changeset, including the author's name: https://github.com/iojs/io.js/pull/552.patch |
dns.lookupService
has wrong header level which made the index display not so elegant. refer to https://iojs.org/api/dns.html