doc: mark --env-file and --env-file-if-exists as stable #59925
Merged
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the referenced issue the feature should be ready to be marked as stable. Refs: nodejs#49148 (comment)
Hilzu
force-pushed
the
stabilize-env-file
branch
from
7828c03 to
265f3b2
Compare
lpinca
approved these changes
Sep 18, 2025
anonrig
approved these changes
Sep 19, 2025
aduh95
reviewed
Sep 23, 2025
aduh95
reviewed
Sep 23, 2025
aduh95
added
the
author ready
anonrig
approved these changes
Sep 23, 2025
gurgunday
approved these changes
Sep 23, 2025
|
Would it make sense to mark as stable |
|
To me it makes sense at least. I'll create a commit marking those as stable as well. The people that know the env system better can comment if it should be included or not. |
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - doc: mark --env-file and --env-file-if-exists as stable ⚠ - doc: use correct terminology for newly stable feature ⚠ - doc: mark `process.loadEnvFile` and `util.parseEnv` as stable ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/17975693366 |
anonrig
approved these changes
Sep 24, 2025
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
|
@anonrig doc-only PRs do not need a Jenkins CI run FYI |
aymen94
approved these changes
Sep 30, 2025
|
The failed CI run is most likely flaky and shouldn't be relevant for this PR as it is just a documentation update. Is there anything else I need to do or is this just waiting to land? |
|
Landed in bb04959 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
As discussed in the referenced issue the feature should be ready to be marked as stable. Refs: #49148 (comment) PR-URL: #59925 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #49148 (comment) the feature should be ready to be marked stable.
The change could probably be picked to v24 and be featured in the change log.
This is my first time contributing to node so let me know if there's any mistakes.