test: ensure that the message event is fired #59952
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Alternative to #59885. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59952 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 703 703
Lines 207826 207826
Branches 40030 40036 +6
==========================================
- Hits 183842 183826 -16
- Misses 15973 15974 +1
- Partials 8011 8026 +15 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Sep 23, 2025
test/parallel/test-worker-message-port-infinite-message-loop.js
Outdated
Show resolved
Hide resolved
jakecastelli
approved these changes
Sep 23, 2025
lpinca
added
request-ci
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - test: ensure that the message event is fired ⚠ - Update test/parallel/test-worker-message-port-infinite-message-loop.js ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/17955820654 |
aduh95
approved these changes
Sep 23, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Use `common.mustCallAtLeast()` to verify that the `'message'` event is fired.
lpinca
force-pushed
the
fix/test-worker-message-port-infinite-message-loop
branch
from
d4d9c67 to
097b5ed
Compare
|
Rebased, this needs new approvals. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jakecastelli
approved these changes
Oct 5, 2025
lpinca
added
commit-queue
|
It seems that #59885 was merged. I'll open a new PR to revert it. |
nodejs-github-bot
removed
the
commit-queue
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 5, 2025
This reverts commit 9790315. Refs: nodejs#59952
|
Landed in 307eaca |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
Use `common.mustCallAtLeast()` to verify that the `'message'` event is fired. PR-URL: #59952 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
common.mustCallAtLeast()to verify that the'message'event is fired.