New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove deprecated Client interface #8104

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
6 participants
@mscdex
Contributor

mscdex commented Aug 14, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http
Description of change

This commit removes the old http Client API that has been (hard) deprecated since 2011/v0.7.0.

@mscdex mscdex force-pushed the mscdex:http-remove-old-client-api branch 2 times, most recently Aug 14, 2016

@mscdex

This comment has been minimized.

Contributor

mscdex commented Aug 14, 2016

CI is green except for an unrelated failure on AIX. CITGM also looks good.

/cc @nodejs/http

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Aug 15, 2016

seems fine to me if ecosystem usage is low enough

@jasnell

This comment has been minimized.

Member

jasnell commented Aug 15, 2016

LGTM

@jasnell jasnell added this to the 7.0.0 milestone Aug 15, 2016

@jasnell

This comment has been minimized.

Member

jasnell commented Aug 15, 2016

Putting on the 7.0.0 milestone

@mscdex mscdex force-pushed the mscdex:http-remove-old-client-api branch Aug 26, 2016

@mscdex

This comment has been minimized.

Contributor

mscdex commented Aug 26, 2016

/cc @nodejs/ctc Comments? Questions? Concerns? Paper? Plastic?

@jasnell

This comment has been minimized.

Member

jasnell commented Aug 26, 2016

Still LGTM... now if only we can get other ctc to weigh in ;-)

@bnoordhuis

This comment has been minimized.

Member

bnoordhuis commented Aug 26, 2016

LGTM

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Aug 26, 2016

@ChALkeR are you able to check npm stats on this at all?

@ChALkeR

This comment has been minimized.

Member

ChALkeR commented Aug 26, 2016

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Aug 26, 2016

Hmm, most of it looks pretty old to me.

@ChALkeR

This comment has been minimized.

Member

ChALkeR commented Aug 26, 2016

242 packages. Top 10 used ones:

 432816  "node-forge"
 425178  "newrelic"
 153046  "nodeunit"
 84993  "node-rest-client"
 62103  "graphviz"
 4878  "npm-registry-couchapp"
 4732  "websocket-client"
 3981  "commonjs-everywhere"
 3596  "pn"
 3502  "felix-couchdb"

Only 5 of those have more than 5000 downloads/month.

@mscdex

This comment has been minimized.

Contributor

mscdex commented Aug 26, 2016

  • node-forge can be dismissed, the usage I found there was actually just it creating its own http namespace with its own createClient() implementation (which isn't even documented).
  • newrelic attempts to wrap the old API, but the way it wraps them it first checks if it exists, and safely exits/returns in case the API does not exist, so that should not be a problem either.
  • nodeunit is a legit case however and I filed a PR for it here.
  • node-rest-client is also another legit case and I filed a PR for it here.
  • graphviz hasn't been updated since 2014 with unanswered issues and PRs, so IMHO I'm not sure it makes sense to try and submit a PR to fix any usage there.
  • npm-registry-couchapp is another legit case and I filed a PR for it here.
  • websocket-client hasn't been updated since 2012, so IMHO I'm not sure it makes sense to try and update that module either.
  • commonjs-everywhere similarly hasn't been updated since 2014
  • pn should be safe since it checks for existence first
  • felix-couchdb is another legit case and I filed a PR here.
@cjihrig

This comment has been minimized.

Contributor

cjihrig commented Aug 27, 2016

LGTM. Doubled bagged.

@mscdex mscdex force-pushed the mscdex:http-remove-old-client-api branch Aug 30, 2016

@mscdex

This comment has been minimized.

Contributor

mscdex commented Aug 30, 2016

http: remove deprecated Client interface
PR-URL: #8104
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@mscdex mscdex force-pushed the mscdex:http-remove-old-client-api branch to 2cc7fa5 Aug 30, 2016

@mscdex mscdex merged commit 2cc7fa5 into nodejs:master Aug 30, 2016

@mscdex mscdex deleted the mscdex:http-remove-old-client-api branch Aug 30, 2016

@ChALkeR ChALkeR removed their assignment Oct 23, 2016

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment