test: add new.target add-on regression test #9689

Merged
merged 1 commit into from Nov 21, 2016

Conversation

Projects
None yet
4 participants
@bnoordhuis
Member

bnoordhuis commented Nov 18, 2016

Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

Refs: #9288
Refs: #9293

CI: https://ci.nodejs.org/job/node-test-pull-request/4900/

@addaleax

LGTM

test/addons/new-target/test.js
+ }
+}
+
+assert.ok(new Class().ok);

This comment has been minimized.

@addaleax

addaleax Nov 18, 2016

Member

Just a suggestion but maybe check new Class() instanceof binding.Class, too?

@addaleax

addaleax Nov 18, 2016

Member

Just a suggestion but maybe check new Class() instanceof binding.Class, too?

This comment has been minimized.

@bnoordhuis

bnoordhuis Nov 18, 2016

Member

Good idea, done. Also fixed the lint warning.

@bnoordhuis

bnoordhuis Nov 18, 2016

Member

Good idea, done. Also fixed the lint warning.

test/addons/new-target/binding.cc
+
+NODE_MODULE(binding, Initialize)
+
+} // namespace anonymous

This comment has been minimized.

@addaleax

addaleax Nov 18, 2016

Member

The linter seems to want anonymous namespace :P

@addaleax

addaleax Nov 18, 2016

Member

The linter seems to want anonymous namespace :P

test: add new.target add-on regression test
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: #9689
Refs: #9288
Refs: #9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@bnoordhuis bnoordhuis closed this Nov 21, 2016

@bnoordhuis bnoordhuis deleted the bnoordhuis:new-target-addon-test branch Nov 21, 2016

@bnoordhuis bnoordhuis merged commit 13c4f44 into nodejs:master Nov 21, 2016

addaleax added a commit that referenced this pull request Nov 22, 2016

test: add new.target add-on regression test
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: #9689
Refs: #9288
Refs: #9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 20, 2016

Member

@bnoordhuis this is causing failures. Can you manually backport?

Member

MylesBorins commented Dec 20, 2016

@bnoordhuis this is causing failures. Can you manually backport?

MylesBorins added a commit that referenced this pull request Dec 20, 2016

test: add new.target add-on regression test
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: #9689
Refs: #9288
Refs: #9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Dec 21, 2016

Member

@thealphanerd The v6.x backport is at #9293 (so I’m removing lts-watch-v6.x) and I am not sure this is feasible for v4.x at all

Member

addaleax commented Dec 21, 2016

@thealphanerd The v6.x backport is at #9293 (so I’m removing lts-watch-v6.x) and I am not sure this is feasible for v4.x at all

MylesBorins added a commit that referenced this pull request Dec 21, 2016

test: add new.target add-on regression test
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: #9689
Refs: #9288
Refs: #9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2016

Merged

V4.7.1 proposal #10395

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Mar 2, 2017

test: add new.target add-on regression test
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: nodejs#9689
Refs: nodejs#9288
Refs: nodejs#9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: add new.target add-on regression test
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.

PR-URL: #9689
Refs: #9288
Refs: #9293
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment