test: add new.target add-on regression test #9689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 18, 2016
| } | ||
| } | ||
|
|
||
| assert.ok(new Class().ok); |
There was a problem hiding this comment.
Just a suggestion but maybe check new Class() instanceof binding.Class, too?
There was a problem hiding this comment.
Good idea, done. Also fixed the lint warning.
|
|
||
| NODE_MODULE(binding, Initialize) | ||
|
|
||
| } // namespace anonymous |
There was a problem hiding this comment.
The linter seems to want anonymous namespace :P
Add a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. PR-URL: nodejs#9689 Refs: nodejs#9288 Refs: nodejs#9293 Reviewed-By: Anna Henningsen <anna@addaleax.net>
bnoordhuis
force-pushed
the
new-target-addon-test
branch
from
2614eca
to
13c4f44
Compare
|
@bnoordhuis this is causing failures. Can you manually backport? |
|
@thealphanerd The v6.x backport is at #9293 (so I’m removing lts-watch-v6.x) and I am not sure this is feasible for v4.x at all |
Merged
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Mar 2, 2017
Add a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. PR-URL: nodejs#9689 Refs: nodejs#9288 Refs: nodejs#9293 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that checks that new.target inheritance works when inheriting
from a constructor defined in C++.
Refs: #9288
Refs: #9293
CI: https://ci.nodejs.org/job/node-test-pull-request/4900/