Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 12, 2022

Description

This PR simply moves files around (no actual code changes) by restructuring the overall src/ folder, having these notable changes:

  • src/components now exports components grouped by their "category"
    • E.g.: BlogComponents, ArticleComponents
    • This allows us to organise better and have a clearer view as the amount of Components is growing exponentially.
  • Moves Layouts to src/layouts
  • Deleted the "Containers" and moved to Components
  • Created a folder for React Providers

Actual Code changes

  • Moved some type exports to src/types
  • Removed usages of useIntl in favour of injectIntl

@ovflowd ovflowd added enhancement New feature or request refactor labels Oct 12, 2022
@ovflowd ovflowd requested a review from aymen94 October 12, 2022 20:21
@ovflowd
Copy link
Member Author

ovflowd commented Oct 12, 2022

Note.: The number of affected files is significant, but there are no changes in the code, just files being moved around and the imports being updated.

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Oct 13, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Oct 13, 2022
@github-actions
Copy link

Please find a preview at: https://staging.nodejs.dev/2921/

@benhalverson benhalverson added the hacktoberfest-accepted Used to label PR's label Oct 13, 2022
Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dog LGTM Keyboard

@ovflowd
Copy link
Member Author

ovflowd commented Oct 13, 2022

Hacktoberfest Accepted label 🤨

Copy link
Member

@manishprivet manishprivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can merge after the linting errors are fixed.

@ovflowd ovflowd removed the hacktoberfest-accepted Used to label PR's label Oct 13, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 66.02% // Head: 66.07% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (3d8e108) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2921      +/-   ##
==========================================
+ Coverage   66.02%   66.07%   +0.05%     
==========================================
  Files         118      136      +18     
  Lines        1351     1530     +179     
  Branches      342      357      +15     
==========================================
+ Hits          892     1011     +119     
- Misses        422      477      +55     
- Partials       37       42       +5     
Impacted Files Coverage Δ
src/__fixtures__/hooks.tsx 100.00% <ø> (ø)
src/__fixtures__/page.tsx 94.11% <ø> (-5.89%) ⬇️
...components/ApiComponents/Components/ApiHeading.tsx 100.00% <ø> (+100.00%) ⬆️
...rc/components/ApiComponents/Components/ApiLink.tsx 100.00% <ø> (+100.00%) ⬆️
...ents/ApiComponents/Components/SourceLink/index.tsx 50.00% <ø> (+50.00%) ⬆️
...ApiComponents/Components/VersionSelector/index.tsx 100.00% <ø> (+100.00%) ⬆️
src/components/ApiComponents/index.tsx 100.00% <ø> (+100.00%) ⬆️
src/components/ArticleComponents/Alert/index.tsx 50.00% <ø> (ø)
...ents/ArticleComponents/AuthorList/Author/index.tsx 88.88% <ø> (ø)
.../components/ArticleComponents/AuthorList/index.tsx 100.00% <ø> (ø)
... and 171 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@benhalverson
Copy link
Member

Hacktoberfest Accepted label 🤨

Are you not participating in hacktoberfest?

@ovflowd
Copy link
Member Author

ovflowd commented Oct 13, 2022

Are you not participating in hacktoberfest?

Maintainers cannot participate afaik (in the projects they're maintainers)

@ovflowd ovflowd merged commit f820d68 into nodejs:main Oct 13, 2022
@ovflowd ovflowd deleted the refactor/reorganise-components branch October 13, 2022 08:09
This was referenced Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants