Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

KwanJunWen
Copy link
Contributor

Description

Added test for component DownloadableItem.

Related Issues

#2744

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 66.02% // Head: 66.40% // Increases project coverage by +0.38% 🎉

Coverage data is based on head (15625f1) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2922      +/-   ##
==========================================
+ Coverage   66.02%   66.40%   +0.38%     
==========================================
  Files         118      136      +18     
  Lines        1351     1530     +179     
  Branches      342      357      +15     
==========================================
+ Hits          892     1016     +124     
- Misses        422      472      +50     
- Partials       37       42       +5     
Impacted Files Coverage Δ
src/__fixtures__/hooks.tsx 100.00% <ø> (ø)
src/__fixtures__/page.tsx 94.11% <ø> (-5.89%) ⬇️
...components/ApiComponents/Components/ApiHeading.tsx 100.00% <ø> (+100.00%) ⬆️
...rc/components/ApiComponents/Components/ApiLink.tsx 100.00% <ø> (+100.00%) ⬆️
...ents/ApiComponents/Components/SourceLink/index.tsx 50.00% <ø> (+50.00%) ⬆️
...ApiComponents/Components/VersionSelector/index.tsx 100.00% <ø> (+100.00%) ⬆️
src/components/ApiComponents/index.tsx 100.00% <ø> (+100.00%) ⬆️
src/components/ArticleComponents/Alert/index.tsx 50.00% <ø> (ø)
...ents/ArticleComponents/AuthorList/Author/index.tsx 88.88% <ø> (ø)
.../components/ArticleComponents/AuthorList/index.tsx 100.00% <ø> (ø)
... and 171 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ron Nod

@benhalverson benhalverson added the hacktoberfest-accepted Used to label PR's label Oct 13, 2022
@manishprivet
Copy link
Member

#2921 refactored the folder structuring in the repo. I think you'll need to update your imports accordingly. @KwanJunWen

@manishprivet manishprivet merged commit 5067d75 into nodejs:main Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Used to label PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants