-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Closed
Labels
good first issueIssues for newcomersIssues for newcomershacktoberfestThis Issue is meant for Hacktoberfest 2023This Issue is meant for Hacktoberfest 2023website redesignIssue/PR part of the Node.js Website RedesignIssue/PR part of the Node.js Website Redesign
Description
Create a inline code <code/>
styling using the new figma design (pagelink).
This isn't a new React component, just a globally styled HTML element we want to illustrate. The primary use case for this styling is `code` tags within rendered markdown/MDX files.
Before You Start...
- Use the Contributor's Guide to learn how to setup your environment, run available commands, and construct proper commits.
- Review the technologies used when building the site, and why they were chosen.
Details
❓ Not sure where to start breaking down the figma? Read this short guide
- Add these code block styles to the existing storybook story file
components/__design__/text.stories.tsx
which will excercise each of the component's states. - Use the new tailwind color and typography system to assign properties. For example, Light
background
uses Neutral/100 per the figma.
There are 2 states to capture within styles and stories:
- Light
- Dark
Open Questions
Could we make this an InlineCodeblock
component and then add it to an MDX provider? That might isolate markdown-driven use cases more, but at the cost of increased complexity. For now, let's show what an <code/>
tag renders like. Perhaps what it looks like within <p>
tag only?
Metadata
Metadata
Assignees
Labels
good first issueIssues for newcomersIssues for newcomershacktoberfestThis Issue is meant for Hacktoberfest 2023This Issue is meant for Hacktoberfest 2023website redesignIssue/PR part of the Node.js Website RedesignIssue/PR part of the Node.js Website Redesign