docs: modernize classes in code snippets #3527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeSapkin
force-pushed
the
docs/modernize-classes
branch
4 times, most recently
from
036323f to
e43a874
Compare
|
@nodejs/documentation |
benhalverson
approved these changes
Sep 21, 2022
|
I know this unfortunately got ignored for a long time, but any chance it can be rebased to resolve the conflicts? @nodejs/website Reviews for this would be good. |
GeorgeSapkin
force-pushed
the
docs/modernize-classes
branch
from
c3deca9 to
74dcf56
Compare
|
@nodejs/domains @nodejs/website This could use a few more reviews. |
SEWeiTung
approved these changes
Oct 7, 2022
Trott
reviewed
Oct 9, 2022
aymen94
approved these changes
Oct 10, 2022
GeorgeSapkin
force-pushed
the
docs/modernize-classes
branch
from
cb9b150 to
b7e6015
Compare
SEWeiTung
pushed a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed a few code snippets in the docs to use the modern class syntax. I've only touched the English bits for now.