Skip to content

Conversation

moazkhan05
Copy link
Contributor

Description

Validation

Related Issues

closes #5704

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@moazkhan05 moazkhan05 requested a review from a team as a code owner August 30, 2023 22:39
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 8:35am

@ovflowd
Copy link
Member

ovflowd commented Aug 31, 2023

Hey there 👋 could you solve the merge conflicts?

@moazkhan05
Copy link
Contributor Author

@ovflowd i'll resolve the conflicts

@moazkhan05
Copy link
Contributor Author

I have resolved the merge conflicts @ovflowd

@ovflowd
Copy link
Member

ovflowd commented Sep 5, 2023

I took over the PR. As these were the final Components blocking the new Website Redesign.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.49% (226/247) 76% (38/50) 85.45% (47/55)

Unit Test Report

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 4.5s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Sep 5, 2023
Merged via the queue into nodejs:main with commit f6f3361 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete Dropdown and LanguageSelector Components

3 participants