Skip to content

Conversation

niyashiyas
Copy link
Contributor

@niyashiyas niyashiyas commented Sep 22, 2023

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 8:44pm

Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments.
Thank you for the contribution! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 3.586s ⏱️

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Sep 24, 2023

There are an stranger things
Capture d’écran 2023-09-24 à 10 56 03

Here an fix svg:

Frame
Frame-2

@niyashiyas
Copy link
Contributor Author

All the required changes were made in Storybook
Horizontal-dark logo was added ,
Horizontal-light logo is updated.
Can you please review it again

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Small improvement need but your are going forward.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmuenzenmeyer
Copy link
Collaborator

hearing no other dissent, we can always address later

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 29, 2023
Merged via the queue into nodejs:main with commit 31697ae Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants