Skip to content

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS requested a review from a team as a code owner October 25, 2023 13:53
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 8:59pm

@RafaelGSS
Copy link
Member Author

@richardlau @mhdawson can you please re-review?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
94.61% (281/297) 76.81% (53/69) 93.33% (56/60)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 7.233s ⏱️

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor suggestions.

@mhdawson
Copy link
Member

@RafaelGSS re-reviewed as requested.

Co-authored-by: Michael Dawson <mdawson@devrus.com>
Signed-off-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS
Copy link
Member Author

@ovflowd is it ok to merge 7883d4a or it must be squashed?

@ovflowd
Copy link
Member

ovflowd commented Oct 26, 2023

Just click add to "merge queue" it will squash the commits automatically 🙃

@bmuenzenmeyer
Copy link
Collaborator

@ovflowd is it ok to merge 7883d4a or it must be squashed?

we have no requirements about the state of the commits - merge away

@RafaelGSS RafaelGSS added this pull request to the merge queue Oct 26, 2023
@RafaelGSS
Copy link
Member Author

Thanks, I wasn't aware of this merge queue feature.

Merged via the queue into main with commit 719d351 Oct 26, 2023
@RafaelGSS RafaelGSS deleted the assessment-openssl branch October 26, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants