-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename "Read streams" example to "Streams Pipeline" #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luciano Mammino <lucianomammino@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Luciano Mammino <lucianomammino@gmail.com>
AugustinMauroy
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! thanks for your first contribution 🎉
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Mar 20, 2024
Lighthouse Results
|
Change makes sense to me :) |
mikeesto
approved these changes
Mar 21, 2024
aymen94
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the "Read Streams" example in the home page to "Streams Pipeline".
This particular example illustrates how to create a complete streaming pipeline. It's not just reading, but it is also transforming (Gzipping) and writing.
I think "Streams pipeline" is a more appropriate and captivating name for it.
Validation
Related Issues
#6491 which removes the unnecessary promisify in favour of
stream/promises
Check List
npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.