Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename "Read streams" example to "Streams Pipeline" #6495

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

lmammino
Copy link
Contributor

@lmammino lmammino commented Mar 20, 2024

Description

This PR renames the "Read Streams" example in the home page to "Streams Pipeline".

This particular example illustrates how to create a complete streaming pipeline. It's not just reading, but it is also transforming (Gzipping) and writing.

I think "Streams pipeline" is a more appropriate and captivating name for it.

Validation

Screenshot 2024-03-20 at 08 11 03

Related Issues

#6491 which removes the unnecessary promisify in favour of stream/promises

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Luciano Mammino <lucianomammino@gmail.com>
@lmammino lmammino requested a review from a team as a code owner March 20, 2024 08:12
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 20, 2024 8:15am

Signed-off-by: Luciano Mammino <lucianomammino@gmail.com>
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! thanks for your first contribution 🎉

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 20, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 90 🟢 100 🟢 92 🔗

@ovflowd
Copy link
Member

ovflowd commented Mar 20, 2024

Change makes sense to me :)

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
80.07% (450/562) 79.55% (144/181) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.425s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Mar 23, 2024
Merged via the queue into nodejs:main with commit 2412d4b Mar 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants