Skip to content

fix: Ensure links maintain green color within bold text #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

fix: Ensure links maintain green color within bold text #7744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce8fb50
fix: ensure links maintain green color within bold text
shashankxrm May 13, 2025
ce69ebb
fix(markdown): ensure links inside bold text retain correct green color
shashankxrm May 14, 2025
0c43fea
test(storybook): add story for bold text and links to cover markdown …
shashankxrm May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/ui-components/__design__/text.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,24 @@ export const HeadingsWithLinks: StoryObj = {
),
};

export const BoldAndLinks: StoryObj = {
render: () => (
<main>
<p>
<strong>Bold text (should inherit normal text color)</strong>
</p>
<p>
<strong>
<a href="#">Bold green link (link inside bold)</a>
</strong>
</p>
<p>
<a href="#">
<strong>Bold green link (bold inside link)</strong>
</a>
</p>
</main>
),
};

export default { title: 'Design System' } as MetaObj;
14 changes: 5 additions & 9 deletions packages/ui-components/styles/markdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,18 @@ main {
h4,
h5,
h6 {
@apply font-semibold
text-neutral-900
dark:text-white;

&[id] a {
@apply text-neutral-900
dark:text-white;
}
}

h1,
h2,
h3,
h4,
h5,
h6,
strong {
@apply font-semibold
text-neutral-900
dark:text-white;
@apply font-semibold;
}

code {
Expand Down
Loading