Skip to content

Conversation

carlos-menezes
Copy link
Contributor

@carlos-menezes carlos-menezes commented May 14, 2025

Description

Fixes a minor typo.

-When you order the pizza, You're in the pending state
+When you order the pizza, you're in the pending state

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

```diff
-When you order the pizza, You're in the pending state
+When you order the pizza, you're in the pending state
```

Signed-off-by: Carlos Menezes <carlos-menezes212@hotmail.com>
@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 18:28
@carlos-menezes carlos-menezes requested a review from a team as a code owner May 14, 2025 18:28
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 14, 2025 6:30pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a minor typo in the "Discover Promises in Node.js" lesson by converting "You're" to "you're" for grammatical consistency.

  • Corrected capitalization in a descriptive sentence to improve readability.

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks good to me 🙂

@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels May 14, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 14, 2025
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Fast tracking.

Copy link
Contributor

github-actions bot commented May 14, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 61 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (2f8da07) to head (839ed79).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7747      +/-   ##
==========================================
+ Coverage   74.85%   74.88%   +0.02%     
==========================================
  Files          98       98              
  Lines        7895     7895              
  Branches      200      200              
==========================================
+ Hits         5910     5912       +2     
+ Misses       1984     1982       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@araujogui araujogui added this pull request to the merge queue May 14, 2025
Merged via the queue into nodejs:main with commit 092d168 May 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants