-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(learn): minor typo in "Discover Promises in Node.js" #7747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
```diff -When you order the pizza, You're in the pending state +When you order the pizza, you're in the pending state ``` Signed-off-by: Carlos Menezes <carlos-menezes212@hotmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a minor typo in the "Discover Promises in Node.js" lesson by converting "You're" to "you're" for grammatical consistency.
- Corrected capitalization in a descriptive sentence to improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, looks good to me 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Fast tracking.
Lighthouse Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7747 +/- ##
==========================================
+ Coverage 74.85% 74.88% +0.02%
==========================================
Files 98 98
Lines 7895 7895
Branches 200 200
==========================================
+ Hits 5910 5912 +2
+ Misses 1984 1982 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Fixes a minor typo.
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.