Skip to content

Conversation

gilad-hoshmand-sage
Copy link
Contributor

Description

Fix the wrong display text

Signed-off-by: Gilad Hoshmand <gilad.hoshmand@sage.com>
@Copilot Copilot AI review requested due to automatic review settings May 20, 2025 10:57
@gilad-hoshmand-sage gilad-hoshmand-sage requested a review from a team as a code owner May 20, 2025 10:57
Copy link

vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 20, 2025 10:58am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the flag name display for Node.js code coverage to match the correct test runner option.

  • Corrects the displayed flag from --experimental-code-coverage to --experimental-test-coverage.

@avivkeller avivkeller changed the title Update collecting-code-coverage.md fix(learn): fix link text in coverage article May 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.05%. Comparing base (663fad9) to head (ad5cdd5).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7761      +/-   ##
==========================================
- Coverage   75.09%   75.05%   -0.04%     
==========================================
  Files          98       98              
  Lines        7914     7914              
  Branches      196      196              
==========================================
- Hits         5943     5940       -3     
- Misses       1970     1973       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

github-actions bot commented May 20, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 72 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@AugustinMauroy
Copy link
Member

I'm fast tracking since it not a breaking change and it's fix an "issue" on code example

@avivkeller avivkeller enabled auto-merge May 20, 2025 12:24
@avivkeller avivkeller added this pull request to the merge queue May 20, 2025
Merged via the queue into nodejs:main with commit 232e7f1 May 20, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants