-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(ui): skeleton animation #7795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures skeleton loading animations are visible by inlining theme variables and adding a dark-mode animation.
- Switches the
@theme
directive toinline
so CSS variables are actually emitted - Adds the
dark:animate-pulse-dark
utility to the Skeleton component for dark-theme support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/ui-components/styles/animations.css | Changed @theme from default to inline for inlined vars |
packages/ui-components/Common/Skeleton/index.module.css | Added dark:animate-pulse-dark to the Skeleton utilities |
Comments suppressed due to low confidence (2)
packages/ui-components/Common/Skeleton/index.module.css:5
- There are no tests covering the dark mode variant for the skeleton component. Consider adding a unit or visual regression test to verify that
dark:animate-pulse-dark
is applied correctly under dark theme.
dark:animate-pulse-dark
packages/ui-components/Common/Skeleton/index.module.css:5
- [nitpick] Consider merging all utility classes into a single @apply statement and ensuring it ends with a semicolon, e.g.,
@apply outline-hidden dark:animate-pulse-dark pointer-events-none animate-pulse cursor-default;
to maintain clarity and prevent potential build issues.
dark:animate-pulse-dark
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7795 +/- ##
==========================================
- Coverage 75.34% 75.33% -0.02%
==========================================
Files 96 96
Lines 7862 7862
Branches 192 192
==========================================
- Hits 5924 5923 -1
- Misses 1937 1938 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fast track.
Description
This PR aims to fix the issue where skeleton (loading) animations were not visible on the page
Validation
Before;

After;

Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.