Skip to content

Conversation

canerakdas
Copy link
Member

Description

As mentioned in this comment #8166 (comment) this PR aims to use the styles defined in Figma for the Progression Sidebar instead of the custom hover and active styles that were previously added

Validation

The Progression Sidebar and Sidebar should appear correctly in both the preview and Chromatic

Related Issues

Related to #8166, Fixes #8179

@canerakdas canerakdas requested a review from a team as a code owner October 6, 2025 17:18
@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 17:18
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 6, 2025 5:19pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refines the hover and active states for the Progression Sidebar to align with Figma design specifications instead of using custom styles.

  • Refactored CSS class structure to separate progression and non-progression sidebar item styling
  • Renamed progressionIcon to hexagonIcon for consistency
  • Removed custom hover effects for progression items to match design system

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.tsx Updated class name reference from progressionIcon to hexagonIcon
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css Restructured CSS to separate progression and standard sidebar item styles, removing custom hover states for progression items

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.63%. Comparing base (e3e16f2) to head (501ff02).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8206      +/-   ##
==========================================
+ Coverage   76.62%   76.63%   +0.01%     
==========================================
  Files         115      115              
  Lines        9614     9614              
  Branches      322      322              
==========================================
+ Hits         7367     7368       +1     
+ Misses       2246     2245       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟠 86 🟢 100 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@ovflowd ovflowd added this pull request to the merge queue Oct 6, 2025
Merged via the queue into nodejs:main with commit 39850b9 Oct 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui:(leftNav): strange hover effect or active
3 participants