-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: download options alignment #8209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes alignment issues in the download options UI by adjusting CSS properties for Skeleton and Select components. The changes ensure proper vertical alignment of select elements on the download page.
- Added
inline-flex
andalign-middle
properties to Skeleton component for consistent alignment - Added
align-middle
property to Select component to match the Skeleton alignment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/ui-components/src/Common/Skeleton/index.module.css | Added inline-flex and align-middle classes to improve skeleton alignment |
packages/ui-components/src/Common/Select/index.module.css | Added align-middle class to ensure consistent select component alignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8209 +/- ##
==========================================
- Coverage 76.64% 76.60% -0.05%
==========================================
Files 115 115
Lines 9618 9618
Branches 322 323 +1
==========================================
- Hits 7372 7368 -4
- Misses 2245 2249 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works!
i was messing with items-center
in my debugging, and missed skeleton completely!
Description
This PR aims to fix the height of the Skeleton used with Select and to adjust the alignment of the select on the download page
Validation
Download select must be aligned
Related Issues
Fixes #8208