Potentially fix #646: certain chests not converting.

The "aggressive mode" introduced in the previous release caused all
chests that were spawned and registered as block entities and then
*later* had a loot table set with `setLootTable were ignored.

Author: noobanidus

src/main/java/noobanidus/mods/lootr/block/entities/TileTicker.java

@@ -32,6 +32,7 @@ public class TileTicker {
   private final static Set<Entry> tileEntries = new ObjectLinkedOpenHashSet<>();
   private final static Set<Entry> pendingEntries = new ObjectLinkedOpenHashSet<>();
   private static boolean tickingList = false;
+  private static boolean alertedLargeQuantity = false;
 
   public static void addEntry(RandomizableContainerBlockEntity incoming ,Level level, BlockPos position) {
     if (ConfigManager.DISABLE.get()) {
@@ -71,16 +72,26 @@ public static void addEntry(RandomizableContainerBlockEntity incoming ,Level lev
       }
     }
 
-    if (incoming.lootTable == null || ConfigManager.isBlacklisted(incoming.lootTable)) {
-      return;
+    if (ConfigManager.AGGRESSIVE_MODE.get()) {
+      if (incoming.lootTable == null || ConfigManager.isBlacklisted(incoming.lootTable)) {
+        return;
+      }
     }
 
     Entry newEntry = new Entry(dimension, position, chunks, ServerLifecycleHooks.getCurrentServer().getTickCount());
     synchronized (listLock) {
       if (tickingList) {
         pendingEntries.add(newEntry);
+        if (pendingEntries.size() > 100 && !alertedLargeQuantity && !ConfigManager.AGGRESSIVE_MODE.get()) {
+          LootrAPI.LOG.error("There are over 100 entries in the pending conversion list without aggressive mode enabled. This may cause TPS issues. If TPS issues persist after first launch, consider enabling aggressive mode in the configuration.");
+          alertedLargeQuantity = true;
+        }
       } else {
         tileEntries.add(newEntry);
+        if (tileEntries.size() > 100 && !alertedLargeQuantity && !ConfigManager.AGGRESSIVE_MODE.get()) {
+          LootrAPI.LOG.error("There are over 100 entries in the conversion list without aggressive mode enabled. This may cause TPS issues. If TPS issues persist after first launch, consider enabling aggressive mode in the configuration.");
+          alertedLargeQuantity = true;
+        }
       }
     }
   }

src/main/java/noobanidus/mods/lootr/config/ConfigManager.java

@@ -49,6 +49,7 @@ public class ConfigManager {
   public static final ForgeConfigSpec.BooleanValue CONVERT_ELYTRAS;
   public static final ForgeConfigSpec.BooleanValue CONVERT_WOODEN_CHESTS;
   public static final ForgeConfigSpec.BooleanValue CONVERT_TRAPPED_CHESTS;
+  public static final ForgeConfigSpec.BooleanValue AGGRESSIVE_MODE;
   public static final ForgeConfigSpec.ConfigValue<List<? extends String>> ADDITIONAL_CHESTS;
   public static final ForgeConfigSpec.ConfigValue<List<? extends String>> ADDITIONAL_TRAPPED_CHESTS;
   // Breaking
@@ -123,6 +124,7 @@ public class ConfigManager {
     List<? extends String> empty = Collections.emptyList();
     Predicate<Object> validator = o -> o instanceof String && ((String) o).contains(":");
     Predicate<Object> modidValidator = o -> o instanceof String && !((String) o).contains(":");
+    AGGRESSIVE_MODE = COMMON_BUILDER.comment("if true, all block entities will be checked before being added to the ticker for an eligible loot table. enable this if a huge quantity of containers are clogging the conversion system; note that aggressive mode may prevent certain chests from properly converted even though eligible").define("aggressive_mode", false);
     REPORT_UNRESOLVED_TABLES = COMMON_BUILDER.comment("lootr will automatically log all unresolved tables (i.e., for containers that have a loot table associated with them but, for whatever reason, the lookup for this table returns empty). setting this option to true additionally informs players when they open containers.").define("report_unresolved_tables", false);
     ADDITIONAL_CHESTS = COMMON_BUILDER.comment("a list of additional chests that should be converted (in the format of [\"modid:name\", \"modid:other_name\"], must be a tile entity instance of RandomizableContainerBlockEntity)").defineList("additional_chests", empty, validator);
     ADDITIONAL_TRAPPED_CHESTS = COMMON_BUILDER.comment("a list of additional trapped chests that should be converted (in the format of [\"modid:name\", \"modid:other_name\"], must be a tile entity instance of RandomizableContainerBlockEntity)").defineList("additional_trapped_chests", empty, validator);

src/main/java/noobanidus/mods/lootr/mixins/MixinRandomizableContainerBlockEntity.java

@@ -0,0 +1,47 @@
+package noobanidus.mods.lootr.mixins;
+
+import net.minecraft.resources.ResourceLocation;
+import net.minecraft.world.level.Level;
+import net.minecraft.world.level.block.entity.RandomizableContainerBlockEntity;
+import noobanidus.mods.lootr.api.blockentity.ILootBlockEntity;
+import noobanidus.mods.lootr.block.entities.TileTicker;
+import noobanidus.mods.lootr.config.ConfigManager;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
+
+@Mixin(RandomizableContainerBlockEntity.class)
+public class MixinRandomizableContainerBlockEntity {
+  @Inject(method = "setLootTable(Lnet/minecraft/resources/ResourceLocation;J)V", at = @At("RETURN"))
+  private void lootrOnSetLootTable(ResourceLocation p_59627_, long p_59628_, CallbackInfo ci) {
+    if (ConfigManager.DISABLE.get() || !ConfigManager.AGGRESSIVE_MODE.get()) {
+      return;
+    }
+
+    RandomizableContainerBlockEntity incoming = (RandomizableContainerBlockEntity) (Object) this;
+
+    if (!incoming.hasLevel() || incoming instanceof ILootBlockEntity) {
+      return;
+    }
+
+    Level level = incoming.getLevel();
+
+    if (level == null) {
+      return; // This should be false because `hasLevel`
+    }
+
+    if (level.isClientSide()) {
+      return;
+    }
+    // By default block entities outside of the world border are
+    // not converted. When the world border changes, you will
+    // need to restart the server.
+    if (ConfigManager.CHECK_WORLD_BORDER.get() && !level.getWorldBorder()
+        .isWithinBounds(incoming.getBlockPos())) {
+      return;
+    }
+
+    TileTicker.addEntry(incoming, level, incoming.getBlockPos());
+  }
+}

src/main/resources/lootr.mixins.json

@@ -9,6 +9,7 @@
     "MixinLevelChunk",
     "MixinPoiType",
     "MixinPoiTypes",
+    "MixinRandomizableContainerBlockEntity",
     "MixinStructureTemplate"
   ],
   "client": [