Fix isInLink tracking and improve recording of transitive deps file: in locks #40

iarna · 2018-08-02T07:47:40Z

Repro test from https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754/10

Also fixes: https://npm.community/t/issue-npm-install-with-local-packages-and-symlinks-enoent/518

@iarna

Fixes: https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754 Credit: @iarna Credit: @jhecking

christoffer-dropbox · 2018-08-10T05:35:18Z

lib/shrinkwrap.js

@@ -110,11 +110,13 @@ function shrinkwrapDeps (deps, top, tree, seen) {
    var childIsOnlyDev = isOnlyDev(child)
    var pkginfo = deps[moduleName(child)] = {}
    var requested = getRequested(child) || child.package._requested || {}
+    var linked = child.isLink || child.isInLInk


var linked = child.isLink || child.isInLInk

child.isInLink?

child.isLink = "This module is a symlink in your node_modules

child.isInLink = "Some parent module of this module is a symlink"

There seems to be a typo with a capital i in Link in isInLink.

Ah, good catch, thank you!

I think it was @christoffer-dropbox who caught it, I just wanted to clarify what I thought he meant.

ElvishJerricco · 2018-09-14T21:41:56Z

Is this going to merged? This seems to be required for file: dependencies to have their own package-lock.json files.

ghost · 2018-09-19T10:33:36Z

With this fix, it is possible to install local packages with dependencies. However, a package-lock.json is not created and an existing one has no effect for those dependencies:
https://npm.community/t/npm-install-does-not-install-transitive-dependencies-of-local-dependency/2264/2?u=cbuchacher

johnrjj · 2018-10-02T21:52:02Z

How can I help get this PR merged ?

ElvishJerricco · 2018-10-07T21:55:25Z

I would also like to help get this merged. Should I just look at why it's failing CI?

jtwebman · 2018-10-23T18:50:00Z

@zkat What do we need to do to get this PR in the next npm release. We are having to run npm 5.6.0 with node 10 till this is fixed as you can't use file:../any folder in projects.

jtwebman · 2018-10-25T21:03:50Z

FYI, I rebased this branch on latest and ran it locally it does fix the issue and I didn't have any other issues with it. Will run it on my local for awhile to see how well it does on my other projects as well. Not sure if that is what @zkat means by needs testing. I don't have access in Travis CI to re-run but @iarna there are a few issues with the tests. https://travis-ci.com/npm/cli/jobs/145118084 Maybe this breaks something else.

jtwebman · 2018-10-25T21:25:39Z

I also can run npm test after rebasing on latest and get no failures for this branch.

jtwebman · 2018-10-25T21:46:43Z

Adding some tests now for this issue. Maybe that is what they want. See PR #86

jtwebman · 2018-10-25T22:13:51Z

@iarna If you want to pull the test from my PR and merge or rebase this on latest I can close my PR. Not trying to take credit just trying to get this merged soon.

ghost · 2018-10-26T05:53:27Z

I think this fix is not correct. Please see #40 (comment) above:
https://npm.community/t/npm-install-does-not-install-transitive-dependencies-of-local-dependency/2264

johnrjj · 2018-10-30T23:13:56Z

@iarna -- Anything we can do to land this PR?

larsgw · 2019-03-16T22:26:26Z

Code from this PR was merged as part of another PR, #86.

iarna · 2019-03-18T02:24:21Z

As @larsgw points out, this has actually been merged, so I'm gonna close this now. =D

aaronArinder · 2019-05-03T20:05:32Z

Thanks for this PR, @iarna: super, super useful. 👍

lkaratun · 2019-05-30T19:09:33Z

Still having this issue on npm@6.9.1-next.0 :(

Partially reverts npm#40/npm#86, keeping the "Don't record linked deps as bundled" part but reverting the "Don't iterate into linked deps" part. It seems that we need to record dependencies of linked deps in order for `npm ci` to work. Fixes https://npm.community/t/6-8-0-npm-ci-fails-with-local-dependency/5385 Fixes https://npm.community/t/npm-ci-fail-to-local-packages/6076

@jfirebaugh

Partially reverts #40/#86, keeping the "Don't record linked deps as bundled" part but reverting the "Don't iterate into linked deps" part. It seems that we need to record dependencies of linked deps in order for `npm ci` to work. Fix: https://npm.community/t/6-8-0-npm-ci-fails-with-local-dependency/5385 Fix: https://npm.community/t/npm-ci-fail-to-local-packages/6076 PR-URL: #216 Credit: @jfirebaugh Close: #216 Reviewed-by: @isaacs EDIT: Updated test to not rely on network and follow latest and greatest test patterns.

spaceneenja · 2020-02-17T13:42:53Z

It's 2020 and I'm down this rabbit hole on 6.13.4 and I think I'm going to pull the trigger and switch to Yarn.

Bumps [read-cmd-shim](https://github.com/npm/read-cmd-shim) from 2.0.0 to 3.0.0. - [Release notes](https://github.com/npm/read-cmd-shim/releases) - [Changelog](https://github.com/npm/read-cmd-shim/blob/main/CHANGELOG.md) - [Commits](npm/read-cmd-shim@v2.0.0...v3.0.0) --- updated-dependencies: - dependency-name: read-cmd-shim dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

iarna added 3 commits August 1, 2018 23:13

inflate-shrinkwrap: Insure modules deep in a linked tree are isInLink

b610af4

Fixes: https://npm.community/t/npm-install-for-package-with-local-dependency-fails/754 Credit: @iarna Credit: @jhecking

shrinkwrap: Don't iterate into linked deps

e694296

shrinkwrap: Don't record linked deps as bundled

03dade9

iarna requested a review from a team as a code owner August 2, 2018 07:47

zkat added semver:patch semver patch level for changes in-progress labels Aug 3, 2018

zkat force-pushed the release-next branch from 6e68d60 to dbbb75c Compare August 9, 2018 04:06

suttitum approved these changes Aug 9, 2018

View reviewed changes

christoffer-dropbox reviewed Aug 10, 2018

View reviewed changes

zkat force-pushed the release-next branch 4 times, most recently from 512c1d5 to f8396dd Compare August 23, 2018 01:24

Update shrinkwrap.js

239a4aa

iarna force-pushed the release-next branch from b62d623 to 03840dc Compare September 12, 2018 17:52

ithinkihaveacat mentioned this pull request Sep 21, 2018

Fix build and enable tests ampproject/ampbench#75

Merged

rarkins mentioned this pull request Sep 27, 2018

chore(deps): update dependency husky to v1 apollographql/apollo-server#1728

Merged

jtwebman mentioned this pull request Oct 25, 2018

Fix issue with sub folder local references #86

Merged

1 task

iarna closed this Mar 18, 2019

jfirebaugh mentioned this pull request Jul 19, 2019

Fix npm ci with file: dependencies #216

Closed

isaacs mentioned this pull request Jul 25, 2019

deps: upgrade npm to 6.10.2 nodejs/node#28853

Closed

This was referenced Aug 13, 2019

[Snyk] Upgrade npm from 6.6.0 to 6.10.2 devopsred/gaia#4

Open

[Snyk] Upgrade npm from 6.10.1 to 6.10.3 tyhal/tyhal.com#104

Merged

This was referenced Aug 30, 2019

[Snyk] Upgrade npm from 6.0.0 to 6.11.1 iliutastoica/30-seconds-of-interviews#1

Open

[Snyk] Upgrade npm from 6.4.1 to 6.11.1 iliutastoica/fullstack-vue#4

Open

[Snyk] Upgrade npm from 6.10.0 to 6.11.2 sandorTuranszky/production-ready-expressjs-server#12

Merged

snyk-bot mentioned this pull request Sep 19, 2019

[Snyk] Upgrade npm from 6.4.1 to 6.11.3 ali8889/etherwallet#1

Open

snyk-bot mentioned this pull request Oct 1, 2019

[Snyk] Upgrade npm from 6.4.1 to 6.11.3 iliutastoica/fullstack-vue#5

Open

This was referenced Oct 26, 2019

[Snyk] Upgrade npm from 6.0.0 to 6.12.0 ajesse11x/30-seconds-of-interviews#1

Open

[Snyk] Upgrade npm from 6.2.0 to 6.12.0 restinpeaceinout/atom#28

Open

This was referenced Nov 5, 2019

[Snyk] Upgrade npm from 6.2.0 to 6.12.0 mvali95/atom#10

Open

[Snyk] Upgrade npm from 6.2.0 to 6.12.1 restinpeaceinout/atom#40

Open

snyk-bot mentioned this pull request Nov 14, 2019

[Snyk] Upgrade npm from 6.2.0 to 6.13.0 restinpeaceinout/atom#49

Open

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade npm from 6.4.1 to 6.13.0 ali8889/etherwallet#7

Open

robertsLando mentioned this pull request Mar 18, 2022

[BUG] npm run changes user using default (1000) instead of root (0) #4589

Closed

2 tasks

nlf deleted the iarna/enoent-on-link-up branch March 28, 2022 16:56

varmakarthik12 mentioned this pull request Nov 30, 2023

[Snyk] Fix for 1 vulnerabilities varmakarthik12/cli#38

Open

gutwrinch mentioned this pull request Jan 6, 2024

[Snyk] Upgrade p-map from 4.0.0 to 7.0.0 gutwrinch/cli-1#20

Open

Kingcrypto38 mentioned this pull request Jan 11, 2024

[Snyk] Upgrade p-map from 4.0.0 to 7.0.0 Kingcrypto38/cli#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix isInLink tracking and improve recording of transitive deps file: in locks #40

Fix isInLink tracking and improve recording of transitive deps file: in locks #40

iarna commented Aug 2, 2018 •

edited

Loading

christoffer-dropbox Aug 10, 2018

iarna Sep 7, 2018

larsgw Sep 11, 2018

iarna Sep 11, 2018

larsgw Sep 12, 2018

ElvishJerricco commented Sep 14, 2018

ghost commented Sep 19, 2018

johnrjj commented Oct 2, 2018

ElvishJerricco commented Oct 7, 2018

jtwebman commented Oct 23, 2018 •

edited

Loading

jtwebman commented Oct 25, 2018 •

edited

Loading

jtwebman commented Oct 25, 2018

jtwebman commented Oct 25, 2018 •

edited

Loading

jtwebman commented Oct 25, 2018

ghost commented Oct 26, 2018

johnrjj commented Oct 30, 2018

larsgw commented Mar 16, 2019

iarna commented Mar 18, 2019

aaronArinder commented May 3, 2019

lkaratun commented May 30, 2019

spaceneenja commented Feb 17, 2020

Fix isInLink tracking and improve recording of transitive deps file: in locks #40

Fix isInLink tracking and improve recording of transitive deps file: in locks #40

Conversation

iarna commented Aug 2, 2018 • edited Loading

christoffer-dropbox Aug 10, 2018

Choose a reason for hiding this comment

iarna Sep 7, 2018

Choose a reason for hiding this comment

larsgw Sep 11, 2018

Choose a reason for hiding this comment

iarna Sep 11, 2018

Choose a reason for hiding this comment

larsgw Sep 12, 2018

Choose a reason for hiding this comment

ElvishJerricco commented Sep 14, 2018

ghost commented Sep 19, 2018

johnrjj commented Oct 2, 2018

ElvishJerricco commented Oct 7, 2018

jtwebman commented Oct 23, 2018 • edited Loading

jtwebman commented Oct 25, 2018 • edited Loading

jtwebman commented Oct 25, 2018

jtwebman commented Oct 25, 2018 • edited Loading

jtwebman commented Oct 25, 2018

ghost commented Oct 26, 2018

johnrjj commented Oct 30, 2018

larsgw commented Mar 16, 2019

iarna commented Mar 18, 2019

aaronArinder commented May 3, 2019

lkaratun commented May 30, 2019

spaceneenja commented Feb 17, 2020

iarna commented Aug 2, 2018 •

edited

Loading

jtwebman commented Oct 23, 2018 •

edited

Loading

jtwebman commented Oct 25, 2018 •

edited

Loading

jtwebman commented Oct 25, 2018 •

edited

Loading