Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack: add dryRun option to packDirectory #47

Merged
merged 3 commits into from Aug 20, 2018
Merged

Conversation

@larsgw
Copy link
Contributor

@larsgw larsgw commented Aug 14, 2018

Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd. Something similar could probably be done for packFromPackage.

See https://npm.community/t/592?u=larsgw

larsgw added 2 commits Aug 14, 2018
Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd.

See https://npm.community/t/592?u=larsgw
Move --dry-run logging closer to original position.
@larsgw larsgw requested a review from as a code owner Aug 14, 2018
Copy link
Contributor

@zkat zkat left a comment

Thank you! This is great. Could you add a small test to make sure the original problem isn't happening anymore with this change?

@larsgw
Copy link
Contributor Author

@larsgw larsgw commented Aug 15, 2018

It's not the prettiest test: the error message doesn't really work, but I believe that's how test/tap/lifecycle-order.js does it.

@larsgw
Copy link
Contributor Author

@larsgw larsgw commented Aug 20, 2018

@zkat, I don't think I can request another review with GitHubs interface, or respond to the first one, but I added a test.

zkat
zkat approved these changes Aug 20, 2018
Copy link
Contributor

@zkat zkat left a comment

Nice! Thanks a bunch. This is a great bug fix! 🎉

@zkat zkat changed the base branch from latest to release-next Aug 20, 2018
@zkat zkat merged commit 641a5ff into npm:release-next Aug 20, 2018
2 checks passed
2 checks passed
@travis-ci[bot]
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zkat added a commit that referenced this issue Aug 20, 2018
Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd.

Fixes: https://npm.community/t/592
PR-URL: #47
Credit: @larsgw
Reviewed-By: @zkat
zkat added a commit that referenced this issue Aug 20, 2018
Add dryRun option to packDirectory. This makes it possible to run postscript after the archive has been written to cwd.

Fixes: https://npm.community/t/592
PR-URL: #47
Credit: @larsgw
Reviewed-By: @zkat
isaacs added a commit that referenced this issue Aug 5, 2019
FEATURES

* [bbcf7b2](npm/hosted-git-info@bbcf7b2)
  [#46](npm/hosted-git-info#46)
  [#43](npm/hosted-git-info#43)
  [#47](npm/hosted-git-info#47)
  [#44](npm/hosted-git-info#44) Add support for
  GitLab groups and subgroups ([@mterrel](https://github.com/mterrel),
  [@isaacs](https://github.com/isaacs),
  [@ybiquitous](https://github.com/ybiquitous))

BUGFIXES

* ([3b1d629](npm/hosted-git-info@3b1d629))
  [#48](npm/hosted-git-info#48) fix http protocol
  using sshurl by default ([@fengmk2](https://github.com/fengmk2))
* [5d4a8d7](npm/hosted-git-info@5d4a8d7) ignore
  noCommittish on tarball url generation
  ([@isaacs](https://github.com/isaacs))
* [1692435](npm/hosted-git-info@1692435) use gist
  tarball url that works for anonymous gists
  ([@isaacs](https://github.com/isaacs))
* [d5cf830](npm/hosted-git-info@d5cf830)
* Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
* [e518222](npm/hosted-git-info@e518222)
  Use LRU cache to prevent unbounded memory consumption
  ([@iarna](https://github.com/iarna))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants