feat(graph): add project details view #20466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
requested review from
FrozenPandaz,
vsavkin,
a team,
philipjfulcher,
bcabanes,
AgentEnder,
jaysoo and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5df9c47. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
MaxKless
force-pushed
the
project-details
branch
from
a60fb5f
to
6220d67
Compare
isaacplmann
approved these changes
Nov 29, 2023
philipjfulcher
approved these changes
Nov 30, 2023
FrozenPandaz
requested changes
Nov 30, 2023
| @@ -749,6 +785,10 @@ async function createExpandedTaskInputResponse( | |||
| return response; | |||
| } | |||
|
|
|||
| function createSourceMapsResponse() { | |||
| return readSourceMaps(); | |||
There was a problem hiding this comment.
This reads it from the file? Can we make a new function which will build a graph and return the source map?
MaxKless
force-pushed
the
project-details
branch
from
d56c37d
to
4da1206
Compare
FrozenPandaz
approved these changes
Dec 4, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very rudimentary Project Details view to the graph app, available under
/project-details/:projectName.You can open this view by calling
nx show project project1 --web.By hovering over individual properties, the source map will be used to display which plugin & file resulted in this property being set.
Disclaimer: the view is ugly and will be improved in the future. More interactivity with the rest of the graph app will also be added.