Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots are a bit constrained #3

Closed
rgbkrk opened this issue May 18, 2015 · 9 comments
Closed

Plots are a bit constrained #3

rgbkrk opened this issue May 18, 2015 · 9 comments
Labels
bug 🐛 For unexpected issues

Comments

@rgbkrk
Copy link
Member

rgbkrk commented May 18, 2015

screenshot 2015-05-17 23 20 23

@rgbkrk
Copy link
Member Author

rgbkrk commented May 18, 2015

On a separate note (and not the fault of Hydrogen), matplotlib should still by default respond with rich output if it can for all frontends. 😫

@willwhitney
Copy link
Collaborator

Hmm, it's weird that it placed that bubble there. It should have been placed at the end of the selected area (by .plot()) and been much wider. Not sure why this is getting cut off.

I found that limiting the size of the bubbles was necessary to keep large images/videos/stacktraces from filling the entire screen — any clever ideas about a better solution?

@willwhitney willwhitney added the bug 🐛 For unexpected issues label May 18, 2015
@rgbkrk
Copy link
Member Author

rgbkrk commented May 18, 2015

The way I was going to lay it out was with a separate pane or tab that can be moved around (the way Atom script was initially created). It would be nice to be able to dock it. One flow that I've considered is a swipable collection of outputs though I really like the output next to run line UI.

@willwhitney
Copy link
Collaborator

Yeah, I've been playing around with designs for throwing the output into a
separate pane (maybe more like a normal REPL pane, maybe something else)
but I haven't landed on anything I really like yet.

I will be adding support for opening multiline results in a new Editor
pane, but that doesn't improve images. Maybe with some fiddling the UI for
images will be good enough as-is.

On Mon, May 18, 2015 at 1:13 PM Kyle Kelley notifications@github.com
wrote:

The way I was going to lay it out was with a separate pane or tab that can
be moved around (the way Atom script was initially created). It would be
nice to be able to dock it. One flow that I've considered is a swipable
collection of outputs though I really like the output next to run line
UI.


Reply to this email directly or view it on GitHub
#3 (comment).

@rgbkrk
Copy link
Member Author

rgbkrk commented May 18, 2015

At least for me, I'm going to want a pane so that I can interact with widgets, Bokeh plots, etc.

There's always the option of making alternative UIs (in separate packages), but sharing common components. Beyond just the Jupyter stuff, some of the code I looked over in Hydrogen is the same stuff we had to do in atom script for contextual running of code (selection, whole file, temp file). Making a Jupyter package for Atom has been high on my list to break away from the script package, so I'm super excited you've gotten this going.

@willwhitney
Copy link
Collaborator

I don't think this particular bug is happening any more, so I'll close the issue.

Still thinking about ways to build a good two-pane experience though.

@rgbkrk
Copy link
Member Author

rgbkrk commented May 19, 2015

After the latest upgrade, I'm still seeing a plot like this:

screenshot 2015-05-19 15 54 30

This is probably because two mimetypes are being displayed instead of just image/png.

@willwhitney willwhitney reopened this May 19, 2015
@willwhitney
Copy link
Collaborator

Ah, I see what's going on. The kernel is sending two separate messages, an execute_result and a display_data. Showing both of them is OK (actually necessary; hard to determine which results to ignore, and doing it wrong is deadly). The issue is that the image was being displayed inline instead of block, so it got pushed . Fix coming.

@willwhitney
Copy link
Collaborator

Closed by 6592b3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 For unexpected issues
Projects
None yet
Development

No branches or pull requests

2 participants